You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "manuzhang (via GitHub)" <gi...@apache.org> on 2026/06/18 13:49:17 UTC
[PR] fix: propagate nested cast errors [datafusion-comet]
manuzhang opened a new pull request, #4675:
URL: https://github.com/apache/datafusion-comet/pull/4675
## Which issue does this PR close?
Part of #4248
## Rationale for this change
Nested struct casts currently unwrap nested cast results while building the output `StructArray`. When a nested cast fails, such as an ANSI overflow inside a struct, that unwrap can panic instead of returning the cast failure as a normal DataFusion error.
## What changes are included in this PR?
- Propagate nested struct cast errors through `DataFusionResult` instead of unwrapping.
- Add coverage for nested struct-to-string casts, nested struct-to-struct casts, array cast ANSI overflow, and expected ANSI failures in the cast helper.
## How are these changes tested?
Updated tests suites and added native UTs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: propagate nested cast errors [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead merged PR #4675:
URL: https://github.com/apache/datafusion-comet/pull/4675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: propagate nested cast errors [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #4675:
URL: https://github.com/apache/datafusion-comet/pull/4675#discussion_r3443853589
##########
.github/workflows/spark_sql_test_reusable.yml:
##########
@@ -81,7 +81,6 @@ jobs:
path: |
~/.cargo/registry
~/.cargo/git
- native/target
Review Comment:
is this change related?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org