You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/11/15 11:38:46 UTC
[GitHub] [incubator-ratis] szetszwo opened a new pull request #279: RATIS-1158. Use the same proto for StateMachineExceptionProto, AlreadyClosedExceptionProto and DataStreamExceptionProto.
szetszwo opened a new pull request #279:
URL: https://github.com/apache/incubator-ratis/pull/279
See https://issues.apache.org/jira/browse/RATIS-1158
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang closed pull request #279: RATIS-1158. Use the same proto for StateMachineExceptionProto, AlreadyClosedExceptionProto and DataStreamExceptionProto.
Posted by GitBox <gi...@apache.org>.
runzhiwang closed pull request #279:
URL: https://github.com/apache/incubator-ratis/pull/279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] amaliujia commented on a change in pull request #279: RATIS-1158. Use the same proto for StateMachineExceptionProto, AlreadyClosedExceptionProto and DataStreamExceptionProto.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #279:
URL: https://github.com/apache/incubator-ratis/pull/279#discussion_r523832837
##########
File path: ratis-proto/src/main/proto/Raft.proto
##########
@@ -321,22 +321,11 @@ message NotReplicatedExceptionProto {
uint64 logIndex = 3;
}
-message StateMachineExceptionProto {
- string exceptionClassName = 1;
- string errorMsg = 2;
- bytes stacktrace = 3;
-}
-
-message AlreadyClosedExceptionProto {
- string exceptionClassName = 1;
- string errorMsg = 2;
- bytes stacktrace = 3;
-}
-
-message DataStreamExceptionProto {
- string exceptionClassName = 1;
- string errorMsg = 2;
- bytes stacktrace = 3;
+message ThrowableProto {
+ string className = 1;
+ string errorMessage = 2;
+ bytes stackTrace = 3;
+ bytes cause = 4;
Review comment:
This is a good simplification 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] szetszwo closed pull request #279: RATIS-1158. Use the same proto for StateMachineExceptionProto, AlreadyClosedExceptionProto and DataStreamExceptionProto.
Posted by GitBox <gi...@apache.org>.
szetszwo closed pull request #279:
URL: https://github.com/apache/incubator-ratis/pull/279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang merged pull request #279: RATIS-1158. Use the same proto for StateMachineExceptionProto, AlreadyClosedExceptionProto and DataStreamExceptionProto.
Posted by GitBox <gi...@apache.org>.
runzhiwang merged pull request #279:
URL: https://github.com/apache/incubator-ratis/pull/279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang closed pull request #279: RATIS-1158. Use the same proto for StateMachineExceptionProto, AlreadyClosedExceptionProto and DataStreamExceptionProto.
Posted by GitBox <gi...@apache.org>.
runzhiwang closed pull request #279:
URL: https://github.com/apache/incubator-ratis/pull/279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang closed pull request #279: RATIS-1158. Use the same proto for StateMachineExceptionProto, AlreadyClosedExceptionProto and DataStreamExceptionProto.
Posted by GitBox <gi...@apache.org>.
runzhiwang closed pull request #279:
URL: https://github.com/apache/incubator-ratis/pull/279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang commented on pull request #279: RATIS-1158. Use the same proto for StateMachineExceptionProto, AlreadyClosedExceptionProto and DataStreamExceptionProto.
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #279:
URL: https://github.com/apache/incubator-ratis/pull/279#issuecomment-727690130
@szetszwo Thanks the patch. I have merged it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang closed pull request #279: RATIS-1158. Use the same proto for StateMachineExceptionProto, AlreadyClosedExceptionProto and DataStreamExceptionProto.
Posted by GitBox <gi...@apache.org>.
runzhiwang closed pull request #279:
URL: https://github.com/apache/incubator-ratis/pull/279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang commented on pull request #279: RATIS-1158. Use the same proto for StateMachineExceptionProto, AlreadyClosedExceptionProto and DataStreamExceptionProto.
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #279:
URL: https://github.com/apache/incubator-ratis/pull/279#issuecomment-727579343
reopen pr to trigger ci
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang closed pull request #279: RATIS-1158. Use the same proto for StateMachineExceptionProto, AlreadyClosedExceptionProto and DataStreamExceptionProto.
Posted by GitBox <gi...@apache.org>.
runzhiwang closed pull request #279:
URL: https://github.com/apache/incubator-ratis/pull/279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org