You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/02 11:37:37 UTC

[GitHub] [pulsar] Nicklee007 commented on a diff in pull request #16915: [fix][client]Fix MaxQueueSize semaphore release leak in createOpSendMsg

Nicklee007 commented on code in PR #16915:
URL: https://github.com/apache/pulsar/pull/16915#discussion_r935462681


##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ProducerSemaphoreTest.java:
##########
@@ -66,7 +66,7 @@ public void testProducerSemaphoreInvalidMessage() throws Exception {
         ProducerImpl<byte[]> producer = (ProducerImpl<byte[]>) pulsarClient.newProducer()
                 .topic("testProducerSemaphoreAcquire")
                 .maxPendingMessages(pendingQueueSize)
-                .enableBatching(false)
+                .enableBatching(true)

Review Comment:
   @Jason918 Add test to cover the batching is disabled case, PTAL Thx.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org