You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2015/01/09 23:00:06 UTC

svn commit: r1650679 - in /ofbiz/branches/release14.12: ./ applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartHelper.java

Author: jleroux
Date: Fri Jan  9 22:00:05 2015
New Revision: 1650679

URL: http://svn.apache.org/r1650679
Log:
"Applied fix from trunk for revision: 1650678" 
------------------------------------------------------------------------
r1650678 | jleroux | 2015-01-09 22:57:56 +0100 (ven. 09 janv. 2015) | 3 lignes

A patch from Christian Carlow  for "Error when adding quantity less than 1 but greater than 0 to cart" https://issues.apache.org/jira/browse/OFBIZ-5941

This error occurs when attempting to add, for instance, an item with quantity 0.1 to the shopping cart: "Quantity must be a positive number"
------------------------------------------------------------------------


Modified:
    ofbiz/branches/release14.12/   (props changed)
    ofbiz/branches/release14.12/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartHelper.java

Propchange: ofbiz/branches/release14.12/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Jan  9 22:00:05 2015
@@ -8,4 +8,4 @@
 /ofbiz/branches/json-integration-refactoring:1634077-1635900
 /ofbiz/branches/multitenant20100310:921280-927264
 /ofbiz/branches/release13.07:1547657
-/ofbiz/trunk:1649742,1650240,1650583,1650642
+/ofbiz/trunk:1649742,1650240,1650583,1650642,1650678

Modified: ofbiz/branches/release14.12/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartHelper.java
URL: http://svn.apache.org/viewvc/ofbiz/branches/release14.12/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartHelper.java?rev=1650679&r1=1650678&r2=1650679&view=diff
==============================================================================
--- ofbiz/branches/release14.12/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartHelper.java (original)
+++ ofbiz/branches/release14.12/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartHelper.java Fri Jan  9 22:00:05 2015
@@ -134,7 +134,7 @@ public class ShoppingCartHelper {
         }
 
         // quantity sanity check
-        if (quantity.compareTo(BigDecimal.ONE) < 0) {
+        if (quantity.compareTo(BigDecimal.ZERO) < 0) {
             String errMsg = UtilProperties.getMessage(resource_error, "cart.quantity_not_positive_number", this.cart.getLocale());
             result = ServiceUtil.returnError(errMsg);
             return result;