You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@guacamole.apache.org by "Michael Jumper (JIRA)" <ji...@apache.org> on 2017/09/25 18:39:00 UTC
[jira] [Created] (GUACAMOLE-395) User "expired" column not actually
queried for MySQL
Michael Jumper created GUACAMOLE-395:
----------------------------------------
Summary: User "expired" column not actually queried for MySQL
Key: GUACAMOLE-395
URL: https://issues.apache.org/jira/browse/GUACAMOLE-395
Project: Guacamole
Issue Type: Bug
Components: guacamole-auth-jdbc-mysql
Reporter: Michael Jumper
Priority: Critical
Though the {{expired}} column of the {{guacamole_user}} table is [correctly mapped for PostgreSQL|https://github.com/apache/incubator-guacamole-client/blob/b90a98946359c9b0b7e4af8571034961d47322fa/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-postgresql/src/main/resources/org/apache/guacamole/auth/jdbc/user/UserMapper.xml#L33-L35]:
{code:xml}
<!-- Result mapper for user objects -->
<resultMap id="UserResultMap" type="org.apache.guacamole.auth.jdbc.user.UserModel" >
...
<result column="disabled" property="disabled" jdbcType="BOOLEAN"/>
<result column="expired" property="expired" jdbcType="BOOLEAN"/>
<result column="access_window_start" property="accessWindowStart" jdbcType="TIME"/>
...
</resultMap>
{code}
it is [not mapped at all for MySQL|https://github.com/apache/incubator-guacamole-client/blob/b90a98946359c9b0b7e4af8571034961d47322fa/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/resources/org/apache/guacamole/auth/jdbc/user/UserMapper.xml#L33-L34]:
{code:xml}
<!-- Result mapper for user objects -->
<resultMap id="UserResultMap" type="org.apache.guacamole.auth.jdbc.user.UserModel" >
...
<result column="disabled" property="disabled" jdbcType="BOOLEAN"/>
<result column="access_window_start" property="accessWindowStart" jdbcType="TIME"/>
...
</resultMap>
{code}
This column [controls manual password expiration|https://github.com/apache/incubator-guacamole-client/blob/728d9b937c80bbf61ac79dd563dc1775203b34e6/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/JDBCAuthenticationProviderService.java#L106-L108], which is thus broken for MySQL and MariaDB databases.
See also: http://guacamole.incubator.apache.org/doc/gug/jdbc-auth.html#jdbc-auth-schema-users
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)