[GitHub] [helix] jiajunwang commented on pull request #2367: Adding retry for flaky tests.

["jiajunwang (via GitHub)" <gi...@apache.org>]

jiajunwang commented on PR #2367:
URL: https://github.com/apache/helix/pull/2367#issuecomment-1416216013

   Thanks for working on improving Helix test. But overall I don't like this kind of changes.
   1. We tried to add retry before, not working well. In many cases, if a test fails, retry will keep failing.
   2. Retry should be added into each test case whenever we determine that a retry fits the test logic. Adding retry to everything blindly just hide problem. It would be much worse if the problem happens in production (where retry won't help).
   3. Based on all the tests that I tried to stablized, the main issue is most possibly in problematic testing logic, like lacking of signal after triggering an async operation, so the test check conditions prematurelly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org