You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "imbajin (via GitHub)" <gi...@apache.org> on 2026/10/12 12:06:02 UTC
[PR] fix(loader): align mapped endpoint fixtures [hugegraph-toolchain]
imbajin opened a new pull request, #811:
URL: https://github.com/apache/hugegraph-toolchain/pull/811
## Purpose of the PR
The source/target value-mapping fixture created vertices such as `p1`, while its edges referenced `person_marko`. The test checked counts and mapped edge fields without proving that those endpoints referred to the loaded vertices.
## Main Changes
- Map custom vertex IDs consistently with the existing edge endpoint mappings in both local-file and HDFS fixtures.
- Enable endpoint checking and assert the exact vertex IDs, labels, typed properties and edge-to-vertex relationships.
## Verifying these changes
- [x] Need tests and can be verified as follows: the original fixture fails the stronger assertions on a disposable RocksDB Server; the fixed functional test passes. Maven test compilation and Checkstyle passed. HDFS inheritance/configuration were checked; a real HDFS run remains pending.
## Does this PR potentially affect the following parts?
- [x] Nope — test fixtures and assertions only
- [ ] Dependencies
- [ ] Modify configurations
- [ ] The public API
## Documentation Status
- [x] `Doc - No Need`
Org review and current-head CI: https://github.com/hugegraph/hugegraph-toolchain/pull/64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(loader): align mapped endpoint fixtures [hugegraph-toolchain]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #811:
URL: https://github.com/apache/hugegraph-toolchain/pull/811#issuecomment-6126773681
## [Codecov](https://app.codecov.io/gh/apache/hugegraph-toolchain/pull/811?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 56.91%. Comparing base ([`e23a93b`](https://app.codecov.io/gh/apache/hugegraph-toolchain/commit/e23a93be061a0e523e4374753f6e2dd0a7dd5088?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`17c11f4`](https://app.codecov.io/gh/apache/hugegraph-toolchain/commit/17c11f43aab5cab4a2c20468dac67acde94cd16f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #811 +/- ##
=============================================
+ Coverage 44.76% 56.91% +12.15%
+ Complexity 3323 1159 -2164
=============================================
Files 377 111 -266
Lines 22488 6258 -16230
Branches 3006 840 -2166
=============================================
- Hits 10066 3562 -6504
+ Misses 11351 2421 -8930
+ Partials 1071 275 -796
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/hugegraph-toolchain/pull/811?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(loader): align mapped endpoint fixtures [hugegraph-toolchain]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #811:
URL: https://github.com/apache/hugegraph-toolchain/pull/811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org