You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Jason Dillaman (JIRA)" <ji...@apache.org> on 2011/07/12 23:49:00 UTC
[jira] [Created] (QPID-3355) Client aborts when replaying sender
after connection recovery
Client aborts when replaying sender after connection recovery
-------------------------------------------------------------
Key: QPID-3355
URL: https://issues.apache.org/jira/browse/QPID-3355
Project: Qpid
Issue Type: Bug
Components: C++ Client
Affects Versions: 0.10, 0.7
Reporter: Jason Dillaman
There is a race condition between qpid::client::SessionImpl::waitForCompletion and qpid::client::SessionImpl::~SessionImpl. If one thread is waiting for a
completion and another thread causes the destructor for the session to be invoked, the destructor can abort the client if waitForCompletion is still holding the state mutex. The reason this occurs is because waitForCompletion is not holding a Waiter::ScopedWait, so the destructor completes while the
mutex is still being held. This was discovered when testing connection loss and recovery.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3355) Client aborts when replaying sender
after connection recovery
Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gordon Sim resolved QPID-3355.
------------------------------
Resolution: Fixed
Fix Version/s: 0.13
> Client aborts when replaying sender after connection recovery
> -------------------------------------------------------------
>
> Key: QPID-3355
> URL: https://issues.apache.org/jira/browse/QPID-3355
> Project: Qpid
> Issue Type: Bug
> Components: C++ Client
> Affects Versions: 0.7, 0.10
> Reporter: Jason Dillaman
> Fix For: 0.13
>
> Attachments: QPID-3355.patch
>
>
> There is a race condition between qpid::client::SessionImpl::waitForCompletion and qpid::client::SessionImpl::~SessionImpl. If one thread is waiting for a
> completion and another thread causes the destructor for the session to be invoked, the destructor can abort the client if waitForCompletion is still holding the state mutex. The reason this occurs is because waitForCompletion is not holding a Waiter::ScopedWait, so the destructor completes while the
> mutex is still being held. This was discovered when testing connection loss and recovery.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3355) Client aborts when replaying sender
after connection recovery
Posted by "Jason Dillaman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Dillaman updated QPID-3355:
---------------------------------
Attachment: QPID-3355.patch
Patch to hold qpid::sys::Waitable::ScopedWait within waitForCompletion
> Client aborts when replaying sender after connection recovery
> -------------------------------------------------------------
>
> Key: QPID-3355
> URL: https://issues.apache.org/jira/browse/QPID-3355
> Project: Qpid
> Issue Type: Bug
> Components: C++ Client
> Affects Versions: 0.7, 0.10
> Reporter: Jason Dillaman
> Attachments: QPID-3355.patch
>
>
> There is a race condition between qpid::client::SessionImpl::waitForCompletion and qpid::client::SessionImpl::~SessionImpl. If one thread is waiting for a
> completion and another thread causes the destructor for the session to be invoked, the destructor can abort the client if waitForCompletion is still holding the state mutex. The reason this occurs is because waitForCompletion is not holding a Waiter::ScopedWait, so the destructor completes while the
> mutex is still being held. This was discovered when testing connection loss and recovery.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3355) Client aborts when replaying sender
after connection recovery
Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064459#comment-13064459 ]
Gordon Sim commented on QPID-3355:
----------------------------------
I have committed this patch since it is logically consistent and may indeed prevent this specific issue. However the root cause is I believe in the messaging implementation above this, where the session is reset while a sync() call is in progress. If the session is referenced while calling sync() then the issue the attached patch fixes won't even occur. Its possible there are other forms of failure possible from the root cause as well so I have fixed that too.
> Client aborts when replaying sender after connection recovery
> -------------------------------------------------------------
>
> Key: QPID-3355
> URL: https://issues.apache.org/jira/browse/QPID-3355
> Project: Qpid
> Issue Type: Bug
> Components: C++ Client
> Affects Versions: 0.7, 0.10
> Reporter: Jason Dillaman
> Fix For: 0.13
>
> Attachments: QPID-3355.patch
>
>
> There is a race condition between qpid::client::SessionImpl::waitForCompletion and qpid::client::SessionImpl::~SessionImpl. If one thread is waiting for a
> completion and another thread causes the destructor for the session to be invoked, the destructor can abort the client if waitForCompletion is still holding the state mutex. The reason this occurs is because waitForCompletion is not holding a Waiter::ScopedWait, so the destructor completes while the
> mutex is still being held. This was discovered when testing connection loss and recovery.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org