You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by johnmccabe <gi...@git.apache.org> on 2016/04/06 19:01:55 UTC
[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...
GitHub user johnmccabe opened a pull request:
https://github.com/apache/brooklyn-dist/pull/31
use host only networking for brooklyn node
- brooklyn accessible on the local node (desktop/laptop where you have run `vagrant up`) via mapped `8081` port at `http://127.0.0.1:8081` which matches the manual install url (simplifies docs)
- can still access the byon nodes on `10.10.10.x` and avoids having to worry about subnet clashes for brooklyn itself
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/johnmccabe/brooklyn-dist enh/brooklyn-vagrant-hostsonly
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-dist/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
----
commit 1bf250df97b15938d36c284966ef0f3fb494352f
Author: John McCabe <jo...@johnmccabe.net>
Date: 2016-04-06T16:56:58Z
use hosts only networking for brooklyn node
- brooklyn accessible via mapped 8081 port at http://127.0.0.1:8081 which matches the manual install url (simplifies docs)
- can still access the byon nodes and avoids having to worry about subnet clashes for brooklyn itself
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/31#discussion_r58748644
--- Diff: vagrant/src/main/vagrant/servers.yaml ---
@@ -41,7 +41,9 @@ servers:
box: ubuntu/wily64
ram: 2048
cpus: 4
- ip: 10.10.10.100
--- End diff --
Why not still include the explicit ip?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-dist/pull/31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...
Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/31#discussion_r58755124
--- Diff: vagrant/src/main/vagrant/servers.yaml ---
@@ -41,7 +41,9 @@ servers:
box: ubuntu/wily64
ram: 2048
cpus: 4
- ip: 10.10.10.100
--- End diff --
Omitting the IP is what switches to host only networking, if you specify an address here it results in Virtualbox creating a new virtual subnet to put the guest on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/31#discussion_r58748556
--- Diff: vagrant/src/main/vagrant/servers.yaml ---
@@ -41,7 +41,9 @@ servers:
box: ubuntu/wily64
ram: 2048
cpus: 4
- ip: 10.10.10.100
+ forwarded_ports:
+ - guest: 8081
+ host: 8081
--- End diff --
If someone has another process listening on port 8081, then presumably `vagrant up brooklyn` will fail with a nice message? Is that ok to assume they won't have anything else running there? I think yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...
Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/31#discussion_r58755945
--- Diff: vagrant/src/main/vagrant/servers.yaml ---
@@ -41,7 +41,9 @@ servers:
box: ubuntu/wily64
ram: 2048
cpus: 4
- ip: 10.10.10.100
--- End diff --
As the doc update is to the website that shouldn't block release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...
Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/31#discussion_r58748964
--- Diff: vagrant/src/main/vagrant/servers.yaml ---
@@ -41,7 +41,9 @@ servers:
box: ubuntu/wily64
ram: 2048
cpus: 4
- ip: 10.10.10.100
+ forwarded_ports:
+ - guest: 8081
+ host: 8081
--- End diff --
If it's a process running in userspace then it will override the mapped port which will become accessible if the overriding process is halted.
Give me a second and I'll check the output from `:auto_correct`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...
Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/31#discussion_r58755772
--- Diff: vagrant/src/main/vagrant/servers.yaml ---
@@ -41,7 +41,9 @@ servers:
box: ubuntu/wily64
ram: 2048
cpus: 4
- ip: 10.10.10.100
--- End diff --
@aledsage I've committed a change that enables `autocorrect`, vagrant will attempt to remap the port if it can - it doesn't work for me (I'll need to have a deeper look at why Vagrant refuses to map the port for me), instead throwing a warning that you're trying to bind to a port that's already in use - see the commit for more information on what happens.
I'm inclined to leave it as-is, and just fix the doc reference to the webconsole url [here](http://brooklyn.apache.org/v/0.9.0-SNAPSHOT/start/running.html#control-apache-brooklyn)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...
Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/31#issuecomment-206465976
fyi @neykov this is related to you comment about the web console url not being correct for Vagrant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-dist/pull/31#issuecomment-206525812
LGTM. Works for me when nothing else is using port 8081.
When there is something else using it, then I get the error message that you refer to in your second commit. I like your comment and instructions in the Vagrantfile - very helpful.
Merging, and will cherry-pick into 0.9.0 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---