[GitHub] [flink] JingsongLi commented on a change in pull request #10878: [FLINK-15599][table] SQL client requires both legacy and blink planner to be on the classpath

[GitBox <gi...@apache.org>]

JingsongLi commented on a change in pull request #10878: [FLINK-15599][table] SQL client requires both legacy and blink planner to be on the classpath
URL: https://github.com/apache/flink/pull/10878#discussion_r368268653
 
 

 ##########
 File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java
 ##########
 @@ -269,12 +272,11 @@ public Pipeline createPipeline(String name, Configuration flinkConfig) {
 		if (streamExecEnv != null) {
 			// special case for Blink planner to apply batch optimizations
 			// note: it also modifies the ExecutionConfig!
-			if (executor instanceof ExecutorBase) {
+			if (isBlinkPlanner) {
 
 Review comment:
   Good point! Catch `NoClassDefFoundError` looks very good to me.
   I've been struggling with this for a long time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services