You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by jo...@apache.org on 2021/05/01 09:34:16 UTC
[commons-fileupload] branch master updated: FILEUPLOAD-325 - Remove
Unused Assignment
This is an automated email from the ASF dual-hosted git repository.
jochen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git
The following commit(s) were added to refs/heads/master by this push:
new ca45aa7 FILEUPLOAD-325 - Remove Unused Assignment
new 1ac8c61 Merge pull request #76 from arturobernalg/feature/FILEUPLOAD-325
ca45aa7 is described below
commit ca45aa7174c1289411dc4371183411e3d2ec5fbf
Author: Arturo Bernal <ar...@gmail.com>
AuthorDate: Sat May 1 11:03:43 2021 +0200
FILEUPLOAD-325 - Remove Unused Assignment
---
src/main/java/org/apache/commons/fileupload2/MultipartStream.java | 4 ++--
src/main/java/org/apache/commons/fileupload2/ParameterParser.java | 4 ++--
.../java/org/apache/commons/fileupload2/MockHttpServletRequest.java | 2 +-
.../apache/commons/fileupload2/jaksrvlt/MockJakSrvltHttpRequest.java | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/main/java/org/apache/commons/fileupload2/MultipartStream.java b/src/main/java/org/apache/commons/fileupload2/MultipartStream.java
index 3011628..e7ff716 100644
--- a/src/main/java/org/apache/commons/fileupload2/MultipartStream.java
+++ b/src/main/java/org/apache/commons/fileupload2/MultipartStream.java
@@ -451,7 +451,7 @@ public class MultipartStream {
public boolean readBoundary()
throws FileUploadIOException, MalformedStreamException {
final byte[] marker = new byte[2];
- boolean nextChunk = false;
+ boolean nextChunk;
head += boundaryLength;
try {
@@ -582,7 +582,7 @@ public class MultipartStream {
baos.write(b);
}
- String headers = null;
+ String headers;
if (headerEncoding != null) {
try {
headers = baos.toString(headerEncoding);
diff --git a/src/main/java/org/apache/commons/fileupload2/ParameterParser.java b/src/main/java/org/apache/commons/fileupload2/ParameterParser.java
index 04e7fd0..929da80 100644
--- a/src/main/java/org/apache/commons/fileupload2/ParameterParser.java
+++ b/src/main/java/org/apache/commons/fileupload2/ParameterParser.java
@@ -303,8 +303,8 @@ public class ParameterParser {
this.pos = offset;
this.len = length;
- String paramName = null;
- String paramValue = null;
+ String paramName;
+ String paramValue;
while (hasChar()) {
paramName = parseToken(new char[] {
'=', separator });
diff --git a/src/test/java/org/apache/commons/fileupload2/MockHttpServletRequest.java b/src/test/java/org/apache/commons/fileupload2/MockHttpServletRequest.java
index 0a69b54..b397941 100644
--- a/src/test/java/org/apache/commons/fileupload2/MockHttpServletRequest.java
+++ b/src/test/java/org/apache/commons/fileupload2/MockHttpServletRequest.java
@@ -310,7 +310,7 @@ public class MockHttpServletRequest implements HttpServletRequest {
*/
@Override
public int getContentLength() {
- int iLength = 0;
+ int iLength;
if (null == m_requestData) {
iLength = -1;
diff --git a/src/test/java/org/apache/commons/fileupload2/jaksrvlt/MockJakSrvltHttpRequest.java b/src/test/java/org/apache/commons/fileupload2/jaksrvlt/MockJakSrvltHttpRequest.java
index 02b658b..1bf1f05 100644
--- a/src/test/java/org/apache/commons/fileupload2/jaksrvlt/MockJakSrvltHttpRequest.java
+++ b/src/test/java/org/apache/commons/fileupload2/jaksrvlt/MockJakSrvltHttpRequest.java
@@ -324,7 +324,7 @@ public class MockJakSrvltHttpRequest implements HttpServletRequest {
*/
@Override
public int getContentLength() {
- int iLength = 0;
+ int iLength;
if (null == m_requestData) {
iLength = -1;