You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by jinfengni <gi...@git.apache.org> on 2016/02/19 01:17:16 UTC
[GitHub] drill pull request: DRILL-4392: Fix CTAS partition to remove one u...
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/383
DRILL-4392: Fix CTAS partition to remove one unnecessary internal fie…
…ld in generated parquet files.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinfengni/incubator-drill DRILL-4392
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/383.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #383
----
commit bc6427685b9b3a7846acbc177cfe6e7e1163ec6e
Author: Jinfeng Ni <jn...@apache.org>
Date: 2016-02-18T23:38:42Z
DRILL-4392: Fix CTAS partition to remove one unnecessary internal field in generated parquet files.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4392: Fix CTAS partition to remove one u...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/383
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4392: Fix CTAS partition to remove one u...
Posted by jinfengni <gi...@git.apache.org>.
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/383#issuecomment-186332099
Right. The planner could not remove that internal field by projection removal, since Writer operator has to use that field. It's the writer's job to exclude that field from the generated files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4392: Fix CTAS partition to remove one u...
Posted by jacques-n <gi...@git.apache.org>.
Github user jacques-n commented on the pull request:
https://github.com/apache/drill/pull/383#issuecomment-186058545
Not projection removal but rather writer rewrite.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4392: Fix CTAS partition to remove one u...
Posted by jacques-n <gi...@git.apache.org>.
Github user jacques-n commented on the pull request:
https://github.com/apache/drill/pull/383#issuecomment-186053195
Fix looks fine. +1
However I think we should open a separate bug that this should be fixed in planning when we add the partition column we should the projection to remove this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---