You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/14 11:04:25 UTC
[GitHub] [shardingsphere] tristaZero opened a new pull request #5607: Use SchemaContexts in ShardingSphereSchema
tristaZero opened a new pull request #5607:
URL: https://github.com/apache/shardingsphere/pull/5607
Ref #5593
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #5607: Use SchemaContexts in ShardingSphereSchema
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #5607:
URL: https://github.com/apache/shardingsphere/pull/5607
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #5607: Use SchemaContexts in ShardingSphereSchema
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5607:
URL: https://github.com/apache/shardingsphere/pull/5607#issuecomment-628587022
## Pull Request Test Coverage Report for [Build 11735](https://coveralls.io/builds/30786088)
* **6** of **11** **(54.55%)** changed or added relevant lines in **2** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage decreased (**-0.01%**) to **59.05%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/datasource/ShardingSphereDataSource.java](https://coveralls.io/builds/30786088/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fdatasource%2FShardingSphereDataSource.java#L74) | 6 | 7 | 85.71%
| [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/context/SchemaContexts.java](https://coveralls.io/builds/30786088/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fcontext%2FSchemaContexts.java#L48) | 0 | 4 | 0.0%
<!-- | **Total:** | **6** | **11** | **54.55%** | -->
| Totals | [](https://coveralls.io/builds/30786088) |
| :-- | --: |
| Change from base [Build 11732](https://coveralls.io/builds/30785276): | -0.01% |
| Covered Lines: | 11941 |
| Relevant Lines: | 20222 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #5607: Use SchemaContexts in ShardingSphereSchema
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #5607:
URL: https://github.com/apache/shardingsphere/pull/5607#issuecomment-628585444
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5607?src=pr&el=h1) Report
> Merging [#5607](https://codecov.io/gh/apache/shardingsphere/pull/5607?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/46be46aefd72e3c832b69234419a692bc5eeda34&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `54.54%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5607?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5607 +/- ##
============================================
- Coverage 55.64% 55.63% -0.01%
Complexity 430 430
============================================
Files 1145 1145
Lines 20217 20222 +5
Branches 3672 3673 +1
============================================
+ Hits 11250 11251 +1
- Misses 8292 8296 +4
Partials 675 675
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5607?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...phere/underlying/common/context/SchemaContext.java](https://codecov.io/gh/apache/shardingsphere/pull/5607/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2NvbnRleHQvU2NoZW1hQ29udGV4dC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...here/underlying/common/context/SchemaContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/5607/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2NvbnRleHQvU2NoZW1hQ29udGV4dHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nderlying/common/context/ShardingSphereSchema.java](https://codecov.io/gh/apache/shardingsphere/pull/5607/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2NvbnRleHQvU2hhcmRpbmdTcGhlcmVTY2hlbWEuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...erlying/common/context/runtime/RuntimeContext.java](https://codecov.io/gh/apache/shardingsphere/pull/5607/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2NvbnRleHQvcnVudGltZS9SdW50aW1lQ29udGV4dC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ere/underlying/executor/kernel/ExecutorKernel.java](https://codecov.io/gh/apache/shardingsphere/pull/5607/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1leGVjdXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdW5kZXJseWluZy9leGVjdXRvci9rZXJuZWwvRXhlY3V0b3JLZXJuZWwuamF2YQ==) | `84.61% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...jdbc/core/datasource/ShardingSphereDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/5607/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvZGF0YXNvdXJjZS9TaGFyZGluZ1NwaGVyZURhdGFTb3VyY2UuamF2YQ==) | `85.71% <85.71%> (+0.42%)` | `0.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5607?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5607?src=pr&el=footer). Last update [46be46a...90100d0](https://codecov.io/gh/apache/shardingsphere/pull/5607?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org