You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2014/09/05 10:33:36 UTC
Review Request 25377: SENTRY-359: Support Sentry service API to
retrieve applicable privileges for a given authorizable object
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25377/
-----------------------------------------------------------
Review request for sentry, Arun Suresh and Sravya Tirukkovalur.
Bugs: SENTRY-359
https://issues.apache.org/jira/browse/SENTRY-359
Repository: sentry
Description
-------
New thirft RPC to fetch all the privileges for the given set of authorizable objects
Also the grant privileges API retuns the new grant object created.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 33600e9
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java d4c5806
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java f227a02
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift b14616b
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java 5244094
Diff: https://reviews.apache.org/r/25377/diff/
Testing
-------
Added new test cases.
Thanks,
Prasad Mujumdar
Re: Review Request 25377: SENTRY-359: Support Sentry service API to
retrieve applicable privileges for a given authorizable object
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25377/#review53761
-----------------------------------------------------------
Ship it!
LGTM. One minor comment: I think we should also add test cases where our roleset/ groups are a subset of available ones. So that we can actually make sure they are being filtered out? Please feel free to file a follow on jira if you agree. Thanks!
- Sravya Tirukkovalur
On Sept. 12, 2014, 4:22 a.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25377/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2014, 4:22 a.m.)
>
>
> Review request for sentry, Arun Suresh and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-359
> https://issues.apache.org/jira/browse/SENTRY-359
>
>
> Repository: sentry
>
>
> Description
> -------
>
> New thirft RPC to fetch all the privileges for the given set of authorizable objects
> Also the grant privileges API retuns the new grant object created.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 718306d
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 6252051
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 070c494
> sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift b14616b
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java 5244094
>
> Diff: https://reviews.apache.org/r/25377/diff/
>
>
> Testing
> -------
>
> Added new test cases.
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 25377: SENTRY-359: Support Sentry service API to
retrieve applicable privileges for a given authorizable object
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25377/
-----------------------------------------------------------
(Updated Sept. 12, 2014, 4:22 a.m.)
Review request for sentry, Arun Suresh and Sravya Tirukkovalur.
Changes
-------
Added optional roleset as filter. Addional testcase.
Bugs: SENTRY-359
https://issues.apache.org/jira/browse/SENTRY-359
Repository: sentry
Description
-------
New thirft RPC to fetch all the privileges for the given set of authorizable objects
Also the grant privileges API retuns the new grant object created.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 718306d
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 6252051
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 070c494
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift b14616b
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java 5244094
Diff: https://reviews.apache.org/r/25377/diff/
Testing
-------
Added new test cases.
Thanks,
Prasad Mujumdar
Re: Review Request 25377: SENTRY-359: Support Sentry service API to
retrieve applicable privileges for a given authorizable object
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25377/
-----------------------------------------------------------
(Updated Sept. 7, 2014, 6:17 p.m.)
Review request for sentry, Arun Suresh and Sravya Tirukkovalur.
Changes
-------
Rebased with latest on master
Bugs: SENTRY-359
https://issues.apache.org/jira/browse/SENTRY-359
Repository: sentry
Description
-------
New thirft RPC to fetch all the privileges for the given set of authorizable objects
Also the grant privileges API retuns the new grant object created.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 718306d
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 6895927
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 070c494
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift b14616b
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java 5244094
Diff: https://reviews.apache.org/r/25377/diff/
Testing
-------
Added new test cases.
Thanks,
Prasad Mujumdar