[jira] [Commented] (ZOOKEEPER-1459) Standalone ZooKeeperServer is not closing the transaction log files on shutdown

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13785818#comment-13785818 ] 

Hadoop QA commented on ZOOKEEPER-1459:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12525047/ZOOKEEPER-1459.patch
  against trunk revision 1529013.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1636//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1636//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1636//console

This message is automatically generated.

> Standalone ZooKeeperServer is not closing the transaction log files on shutdown
> -------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1459
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1459
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.0
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>             Fix For: 3.4.6, 3.5.0
>
>         Attachments: ZOOKEEPER-1459.patch
>
>
> When shutdown the standalone ZK server, its only clearing the zkdatabase and not closing the transaction log streams. This will leaks the transaction log streams.
> ZooKeeperServer.java
> {noformat}
>         if (zkDb != null) {
>             zkDb.clear();
>         }
> {noformat}
> Suggestion to close the zkDb as follows, this inturn will take care transaction logs:
> {noformat}
>         if (zkDb != null) {
>             zkDb.clear();
>             try {
>                 zkDb.close();
>             } catch (IOException ie) {
>                 LOG.warn("Error closing logs ", ie);
>             }
>         }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.1#6144)