You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/01/30 09:01:33 UTC
[GitHub] [incubator-gobblin] codecov-io edited a comment on pull request #3219: [GOBBLIN-1379] Fix retries in DataWriter
codecov-io edited a comment on pull request #3219:
URL: https://github.com/apache/incubator-gobblin/pull/3219#issuecomment-770179493
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3219?src=pr&el=h1) Report
> Merging [#3219](https://codecov.io/gh/apache/incubator-gobblin/pull/3219?src=pr&el=desc) (a154b0c) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/5ecf9a175d745e1b2b46bea5de4ba89512866e5e?el=desc) (5ecf9a1) will **decrease** coverage by `0.07%`.
> The diff coverage is `92.30%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3219?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3219 +/- ##
============================================
- Coverage 46.26% 46.19% -0.08%
+ Complexity 9796 9776 -20
============================================
Files 2019 2019
Lines 77506 77555 +49
Branches 8607 8612 +5
============================================
- Hits 35861 35824 -37
- Misses 38310 38400 +90
+ Partials 3335 3331 -4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3219?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...nt/copy/writer/FileAwareInputStreamDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvd3JpdGVyL0ZpbGVBd2FyZUlucHV0U3RyZWFtRGF0YVdyaXRlci5qYXZh) | `72.19% <85.71%> (+0.55%)` | `40.00 <1.00> (+2.00)` | |
| [...in/java/org/apache/gobblin/writer/RetryWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9SZXRyeVdyaXRlci5qYXZh) | `69.69% <100.00%> (+1.95%)` | `9.00 <0.00> (ø)` | |
| [...lin/metrics/kafka/KafkaKeyValueProducerPusher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9tZXRyaWNzL2thZmthL0thZmthS2V5VmFsdWVQcm9kdWNlclB1c2hlci5qYXZh) | `0.00% <0.00%> (-82.76%)` | `0.00% <0.00%> (-7.00%)` | |
| [...che/gobblin/metrics/kafka/KafkaProducerPusher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9tZXRyaWNzL2thZmthL0thZmthUHJvZHVjZXJQdXNoZXIuamF2YQ==) | `0.00% <0.00%> (-82.15%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/gobblin/kafka/serialize/LiAvroDeserializer.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9rYWZrYS9zZXJpYWxpemUvTGlBdnJvRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ache/gobblin/kafka/serialize/LiAvroSerializer.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9rYWZrYS9zZXJpYWxpemUvTGlBdnJvU2VyaWFsaXplci5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apache/gobblin/kafka/writer/Kafka1DataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9rYWZrYS93cml0ZXIvS2Fma2ExRGF0YVdyaXRlci5qYXZh) | `0.00% <0.00%> (-46.16%)` | `0.00% <0.00%> (-9.00%)` | |
| [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `40.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (-1.00%)` | |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `92.85% <0.00%> (-7.15%)` | `3.00% <0.00%> (-1.00%)` | |
| [...n/java/org/apache/gobblin/yarn/YarnHelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFybkhlbGl4VXRpbHMuamF2YQ==) | `26.66% <0.00%> (-6.03%)` | `9.00% <0.00%> (+1.00%)` | :arrow_down: |
| ... and [21 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3219?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3219?src=pr&el=footer). Last update [5ecf9a1...a154b0c](https://codecov.io/gh/apache/incubator-gobblin/pull/3219?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org