You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Phillips <no...@github.com> on 2014/04/01 13:44:06 UTC

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

> @@ -43,6 +56,24 @@ public CloudFilesCDNApiLiveTest() {
>        super();
>     }
>  
> +   public void testEnable() throws Exception {
> +      for (String regionId : regions) {
> +         assertNotNull(api.cdnApiInRegion(regionId).enable(name));
> +      }
> +   }
> +
> +   public void testEnableWithTTL() throws Exception {
> +      for (String regionId : regions) {
> +         assertNotNull(api.cdnApiInRegion(regionId).enable(name, 777777));
> +      }
> +   }
> +
> +   public void testDisable() throws Exception {
> +      for (String regionId : regions) {
> +         assertNotNull(api.cdnApiInRegion(regionId).disable(name));

Sorry, I didn't express myself clearly, and didn't check the test clearly enough :-( `disable` returns a boolean, from what I can see? So should we be testing for `true` here?

I don't think we need to check (here or below) that **all** fields are non-null.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/85/files#r11156413