You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/26 05:01:41 UTC
[GitHub] [spark] dchvn opened a new pull request #34392: [SPARK-37116][PYTHON] Allow sequences (tuples and lists) as pivot values argument in PySpark
dchvn opened a new pull request #34392:
URL: https://github.com/apache/spark/pull/34392
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->Allow sequences (tuples and lists) as pivot values argument in PySpark.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->Both tuples and lists are accepted by PySpark on runtime.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->Existing Tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34392: [SPARK-37116][PYTHON] Allow sequences (tuples and lists) as pivot values argument in PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34392:
URL: https://github.com/apache/spark/pull/34392#issuecomment-951589301
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144612/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34392: [SPARK-37116][PYTHON] Allow sequences (tuples and lists) as pivot values argument in PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34392:
URL: https://github.com/apache/spark/pull/34392#issuecomment-951563244
cc @zero323 FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dchvn commented on pull request #34392: [SPARK-37116][PYTHON] Allow sequences (tuples and lists) as pivot values argument in PySpark
Posted by GitBox <gi...@apache.org>.
dchvn commented on pull request #34392:
URL: https://github.com/apache/spark/pull/34392#issuecomment-951668518
> Sorry, but it is not correct. `Sequence` is a very high level and, even if we consider only built-in types, covers more than `List` and `Tuples`. In some cases, we might be fine with using `Sequences` (assuming code is properly adjusted), but definitely not here.
This PR is created from [#33083](https://github.com/apache/spark/pull/33083). Thanks for your information, @zero323 , I will close this PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34392: [SPARK-37116][PYTHON] Allow sequences (tuples and lists) as pivot values argument in PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34392:
URL: https://github.com/apache/spark/pull/34392#issuecomment-951589301
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144612/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34392: [SPARK-37116][PYTHON] Allow sequences (tuples and lists) as pivot values argument in PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34392:
URL: https://github.com/apache/spark/pull/34392#issuecomment-951563265
**[Test build #144612 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144612/testReport)** for PR 34392 at commit [`77ef607`](https://github.com/apache/spark/commit/77ef607f0e3875cde008603821c3e0bd150c5dc4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 edited a comment on pull request #34392: [SPARK-37116][PYTHON] Allow sequences (tuples and lists) as pivot values argument in PySpark
Posted by GitBox <gi...@apache.org>.
zero323 edited a comment on pull request #34392:
URL: https://github.com/apache/spark/pull/34392#issuecomment-951674675
Since #33083, the idea of `Sequence` or `Iterable` popped up again, an it might be nice to use it, but sadly it is not that simple.
Among other things, this would type check
```python
from pyspark.sql import SparkSession
spark = SparkSession.builder.getOrCreate()
(spark.read
.csv("foo.csv")
.groupBy("foo")
.pivot("bar", "baz")
.sum())
````
and that's clearly not correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34392: [SPARK-37116][PYTHON] Allow sequences (tuples and lists) as pivot values argument in PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34392:
URL: https://github.com/apache/spark/pull/34392#issuecomment-951622075
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49082/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34392: [SPARK-37116][PYTHON] Allow sequences (tuples and lists) as pivot values argument in PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34392:
URL: https://github.com/apache/spark/pull/34392#issuecomment-951575334
**[Test build #144612 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144612/testReport)** for PR 34392 at commit [`77ef607`](https://github.com/apache/spark/commit/77ef607f0e3875cde008603821c3e0bd150c5dc4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #34392: [SPARK-37116][PYTHON] Allow sequences (tuples and lists) as pivot values argument in PySpark
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34392:
URL: https://github.com/apache/spark/pull/34392#issuecomment-951674675
Since #33083 the idea of `Sequence` or `Iterable` popped up again, an it might be nice to use it, but sadly it is not that simple.
Among other things, this would type check
```python
from pyspark.sql import SparkSession
spark = SparkSession.builder.getOrCreate()
(spark.read
.csv("foo.csv")
.groupBy("foo")
.pivot("bar", "baz")
.sum())
````
and that's clearly not correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #34392: [SPARK-37116][PYTHON] Allow sequences (tuples and lists) as pivot values argument in PySpark
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34392:
URL: https://github.com/apache/spark/pull/34392#issuecomment-951659706
Sorry, but it is not correct. `Sequence` is a very high level and, even if we consider only built-in types, covers more than `List` and `Tuples`. In some cases, we might be fine with using `Sequences` (assuming code is properly adjusted), but definitely not here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34392: [SPARK-37116][PYTHON] Allow sequences (tuples and lists) as pivot values argument in PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34392:
URL: https://github.com/apache/spark/pull/34392#issuecomment-951622075
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49082/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34392: [SPARK-37116][PYTHON] Allow sequences (tuples and lists) as pivot values argument in PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34392:
URL: https://github.com/apache/spark/pull/34392#issuecomment-951606496
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49082/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34392: [SPARK-37116][PYTHON] Allow sequences (tuples and lists) as pivot values argument in PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34392:
URL: https://github.com/apache/spark/pull/34392#issuecomment-951563265
**[Test build #144612 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144612/testReport)** for PR 34392 at commit [`77ef607`](https://github.com/apache/spark/commit/77ef607f0e3875cde008603821c3e0bd150c5dc4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34392: [SPARK-37116][PYTHON] Allow sequences (tuples and lists) as pivot values argument in PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34392:
URL: https://github.com/apache/spark/pull/34392#issuecomment-951584583
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49082/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dchvn closed pull request #34392: [SPARK-37116][PYTHON] Allow sequences (tuples and lists) as pivot values argument in PySpark
Posted by GitBox <gi...@apache.org>.
dchvn closed pull request #34392:
URL: https://github.com/apache/spark/pull/34392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org