You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/22 02:54:04 UTC
[GitHub] [flink] libenchao opened a new pull request #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
libenchao opened a new pull request #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180
… to object reuse
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Fix JsonRowSerializationSchema cast exception.
## Brief change log
Add instantof before cast to avoid nested array/map/row cast exception.
## Verifying this change
This change added tests and can be verified as follows:
- JsonRowSerializationSchemaTest.testNestedSchema()
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#issuecomment-589914664
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"triggerType" : "PUSH"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5448",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
}, {
"hash" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153679310",
"triggerID" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"triggerType" : "PUSH"
}, {
"hash" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6327",
"triggerID" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"triggerType" : "PUSH"
}, {
"hash" : "142438bb79505c78246151b6e13bb163300a73a3",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154025288",
"triggerID" : "142438bb79505c78246151b6e13bb163300a73a3",
"triggerType" : "PUSH"
}, {
"hash" : "142438bb79505c78246151b6e13bb163300a73a3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6380",
"triggerID" : "142438bb79505c78246151b6e13bb163300a73a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 142438bb79505c78246151b6e13bb163300a73a3 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154025288) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6380)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on a change in pull request #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
libenchao commented on a change in pull request #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#discussion_r393648591
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowSerializationSchema.java
##########
@@ -360,7 +360,8 @@ private SerializationRuntimeConverter assembleRowConverter(
return (mapper, reuse, object) -> {
ObjectNode node;
- if (reuse == null) {
+ // reuse could be a NullNode if last record is null.
+ if (!(reuse instanceof ObjectNode)) {
Review comment:
Yes, I write it like `if (reuse == null || !(reuse instanceof ObjectNode))` for the first version. But the IDE suggests to remove `reuse == null` because `instanceof` can cover that.
However, your way seems more straight forward, and the IDE won't complain about it. I'll change it this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#discussion_r393639396
##########
File path: flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/JsonRowSerializationSchemaTest.java
##########
@@ -113,6 +114,12 @@ public void testNestedSchema() {
assertThat(row, whenSerializedWith(serializationSchema)
.andDeserializedWith(deserializationSchema)
.equalsTo(row));
+
+ row.setField(3, new int[]{1, 2, 3});
+
+ assertThat(row, whenSerializedWith(serializationSchema)
Review comment:
This test can't reproduce the problem. I woudl suggest to have another test, e.g. (of course, we should add null array into it)
```java
@Test
public void test() throws IOException {
String[] jsons = new String[] {
"{\"svt\":\"2020-02-24T12:58:09.209+0800\"}",
"{\"svt\":\"2020-02-24T12:58:09.209+0800\", \"ops\":{\"id\":\"281708d0-4092-4c21-9233-931950b6eccf\"}}",
"{\"svt\":\"2020-02-24T12:58:09.209+0800\"}",
};
String[] expected = new String[] {
"{\"svt\":\"2020-02-24T12:58:09.209+0800\",\"ops\":null}",
"{\"svt\":\"2020-02-24T12:58:09.209+0800\",\"ops\":{\"id\":\"281708d0-4092-4c21-9233-931950b6eccf\"}}",
"{\"svt\":\"2020-02-24T12:58:09.209+0800\",\"ops\":null}",
};
TypeInformation<Row> schema = Types.ROW_NAMED(
new String[]{"svt", "ops"},
Types.STRING,
Types.ROW_NAMED(new String[]{"id"}, Types.STRING));
JsonRowDeserializationSchema deserializationSchema = new JsonRowDeserializationSchema.Builder(schema)
.build();
JsonRowSerializationSchema serializationSchema = JsonRowSerializationSchema.builder()
.withTypeInfo(schema)
.build();
for (int i = 0; i < jsons.length; i++) {
String json = jsons[i];
Row row = deserializationSchema.deserialize(json.getBytes());
String result = new String(serializationSchema.serialize(row));
assertEquals(expected[i], result);
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong merged pull request #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#issuecomment-589914664
<!--
Meta data
Hash:56c928ea39dc0c1b9de3e2669d8e48994b208010 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/150126022 TriggerType:PUSH TriggerID:56c928ea39dc0c1b9de3e2669d8e48994b208010
-->
## CI report:
* 56c928ea39dc0c1b9de3e2669d8e48994b208010 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150126022)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#issuecomment-589914664
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"triggerType" : "PUSH"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5448",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
}, {
"hash" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153679310",
"triggerID" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"triggerType" : "PUSH"
}, {
"hash" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6327",
"triggerID" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f1cf2dd26b61af5f530525b09a96a5ac25f5df3f Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/153679310) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6327)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#discussion_r394773884
##########
File path: flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/JsonRowSerializationSchemaTest.java
##########
@@ -91,20 +91,51 @@ public void testSerializationOfTwoRows() throws IOException {
assertEquals(row2, deserializationSchema.deserialize(bytes));
}
+ @Test
+ public void testMultiRowsWithNullValues() throws IOException {
+ String[] jsons = new String[] {
+ "{\"svt\":\"2020-02-24T12:58:09.209+0800\"}",
+ "{\"svt\":\"2020-02-24T12:58:09.209+0800\", \"ops\":{\"id\":\"281708d0-4092-4c21-9233-931950b6eccf\"}}",
+ "{\"svt\":\"2020-02-24T12:58:09.209+0800\"}",
+ };
+
+ String[] expected = new String[] {
+ "{\"svt\":\"2020-02-24T12:58:09.209+0800\",\"ops\":null}",
+ "{\"svt\":\"2020-02-24T12:58:09.209+0800\",\"ops\":{\"id\":\"281708d0-4092-4c21-9233-931950b6eccf\"}}",
+ "{\"svt\":\"2020-02-24T12:58:09.209+0800\",\"ops\":null}",
+ };
+
+ TypeInformation<Row> schema = Types.ROW_NAMED(
+ new String[]{"svt", "ops"},
+ Types.STRING,
+ Types.ROW_NAMED(new String[]{"id"}, Types.STRING));
Review comment:
Could you also verify for array type?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#issuecomment-589914664
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"triggerType" : "PUSH"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5448",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 56c928ea39dc0c1b9de3e2669d8e48994b208010 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150126022) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5448)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#issuecomment-589914664
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"triggerType" : "PUSH"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5448",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
}, {
"hash" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153679310",
"triggerID" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"triggerType" : "PUSH"
}, {
"hash" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6327",
"triggerID" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"triggerType" : "PUSH"
}, {
"hash" : "142438bb79505c78246151b6e13bb163300a73a3",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154025288",
"triggerID" : "142438bb79505c78246151b6e13bb163300a73a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f1cf2dd26b61af5f530525b09a96a5ac25f5df3f Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/153679310) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6327)
* 142438bb79505c78246151b6e13bb163300a73a3 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154025288)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#issuecomment-589910357
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 56c928ea39dc0c1b9de3e2669d8e48994b208010 (Sat Feb 22 02:55:54 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-16220).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#issuecomment-589914664
<!--
Meta data
Hash:56c928ea39dc0c1b9de3e2669d8e48994b208010 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:56c928ea39dc0c1b9de3e2669d8e48994b208010
-->
## CI report:
* 56c928ea39dc0c1b9de3e2669d8e48994b208010 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on a change in pull request #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
libenchao commented on a change in pull request #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#discussion_r394782478
##########
File path: flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/JsonRowSerializationSchemaTest.java
##########
@@ -91,20 +91,51 @@ public void testSerializationOfTwoRows() throws IOException {
assertEquals(row2, deserializationSchema.deserialize(bytes));
}
+ @Test
+ public void testMultiRowsWithNullValues() throws IOException {
+ String[] jsons = new String[] {
+ "{\"svt\":\"2020-02-24T12:58:09.209+0800\"}",
+ "{\"svt\":\"2020-02-24T12:58:09.209+0800\", \"ops\":{\"id\":\"281708d0-4092-4c21-9233-931950b6eccf\"}}",
+ "{\"svt\":\"2020-02-24T12:58:09.209+0800\"}",
+ };
+
+ String[] expected = new String[] {
+ "{\"svt\":\"2020-02-24T12:58:09.209+0800\",\"ops\":null}",
+ "{\"svt\":\"2020-02-24T12:58:09.209+0800\",\"ops\":{\"id\":\"281708d0-4092-4c21-9233-931950b6eccf\"}}",
+ "{\"svt\":\"2020-02-24T12:58:09.209+0800\",\"ops\":null}",
+ };
+
+ TypeInformation<Row> schema = Types.ROW_NAMED(
+ new String[]{"svt", "ops"},
+ Types.STRING,
+ Types.ROW_NAMED(new String[]{"id"}, Types.STRING));
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#issuecomment-589914664
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"triggerType" : "PUSH"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5448",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
}, {
"hash" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153679310",
"triggerID" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"triggerType" : "PUSH"
}, {
"hash" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6327",
"triggerID" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"triggerType" : "PUSH"
}, {
"hash" : "142438bb79505c78246151b6e13bb163300a73a3",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154025288",
"triggerID" : "142438bb79505c78246151b6e13bb163300a73a3",
"triggerType" : "PUSH"
}, {
"hash" : "142438bb79505c78246151b6e13bb163300a73a3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6380",
"triggerID" : "142438bb79505c78246151b6e13bb163300a73a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 142438bb79505c78246151b6e13bb163300a73a3 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154025288) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6380)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#issuecomment-589914664
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56c928ea39dc0c1b9de3e2669d8e48994b208010 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150126022)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on a change in pull request #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
libenchao commented on a change in pull request #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#discussion_r393652961
##########
File path: flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/JsonRowSerializationSchemaTest.java
##########
@@ -113,6 +114,12 @@ public void testNestedSchema() {
assertThat(row, whenSerializedWith(serializationSchema)
.andDeserializedWith(deserializationSchema)
.equalsTo(row));
+
+ row.setField(3, new int[]{1, 2, 3});
+
+ assertThat(row, whenSerializedWith(serializationSchema)
Review comment:
Current test can reproduce the problem, because `serializationSchema` is used twice, for the first time, `f4` is `null`, and for the second time, `f4` is not `null`.
However the test maybe not straight forward and a little fragile which depends on the first use of `serializationSchema`. I'll add a separate test for this like your example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#issuecomment-589914664
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"triggerType" : "PUSH"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 56c928ea39dc0c1b9de3e2669d8e48994b208010 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150126022)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
libenchao commented on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#issuecomment-592568199
@wuchong Could you help to review this pr when you have time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#issuecomment-589914664
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"triggerType" : "PUSH"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5448",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
}, {
"hash" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56c928ea39dc0c1b9de3e2669d8e48994b208010 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150126022) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5448)
* f1cf2dd26b61af5f530525b09a96a5ac25f5df3f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
libenchao commented on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#issuecomment-600105662
@wuchong Thanks for the review. I've addressed your comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#issuecomment-589914664
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"triggerType" : "PUSH"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5448",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
}, {
"hash" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153679310",
"triggerID" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56c928ea39dc0c1b9de3e2669d8e48994b208010 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150126022) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5448)
* f1cf2dd26b61af5f530525b09a96a5ac25f5df3f Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/153679310)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
libenchao commented on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#issuecomment-592573498
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#discussion_r393636044
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowSerializationSchema.java
##########
@@ -360,7 +360,8 @@ private SerializationRuntimeConverter assembleRowConverter(
return (mapper, reuse, object) -> {
ObjectNode node;
- if (reuse == null) {
+ // reuse could be a NullNode if last record is null.
+ if (!(reuse instanceof ObjectNode)) {
Review comment:
Have you considered to use `if (reuse == null || reuse.isNull())` which might be more straightforward?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#issuecomment-589914664
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"triggerType" : "PUSH"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5448",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 56c928ea39dc0c1b9de3e2669d8e48994b208010 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150126022) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5448)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#issuecomment-589914664
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"triggerType" : "PUSH"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5448",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
}, {
"hash" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153679310",
"triggerID" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"triggerType" : "PUSH"
}, {
"hash" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6327",
"triggerID" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f1cf2dd26b61af5f530525b09a96a5ac25f5df3f Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/153679310) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6327)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#issuecomment-589914664
<!--
Meta data
Hash:56c928ea39dc0c1b9de3e2669d8e48994b208010 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/150126022 TriggerType:PUSH TriggerID:56c928ea39dc0c1b9de3e2669d8e48994b208010
-->
## CI report:
* 56c928ea39dc0c1b9de3e2669d8e48994b208010 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150126022)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11180: [FLINK-16220][json] Fix JsonRowSerializationSchema cast exception due…
URL: https://github.com/apache/flink/pull/11180#issuecomment-589914664
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"triggerType" : "PUSH"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150126022",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
}, {
"hash" : "56c928ea39dc0c1b9de3e2669d8e48994b208010",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5448",
"triggerID" : "592573498",
"triggerType" : "MANUAL"
}, {
"hash" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153679310",
"triggerID" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"triggerType" : "PUSH"
}, {
"hash" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6327",
"triggerID" : "f1cf2dd26b61af5f530525b09a96a5ac25f5df3f",
"triggerType" : "PUSH"
}, {
"hash" : "142438bb79505c78246151b6e13bb163300a73a3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "142438bb79505c78246151b6e13bb163300a73a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f1cf2dd26b61af5f530525b09a96a5ac25f5df3f Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/153679310) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6327)
* 142438bb79505c78246151b6e13bb163300a73a3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services