You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mehul Parikh <me...@freestoneinfotech.com> on 2016/11/24 07:29:09 UTC
Review Request 54054: RANGER-1227 : UI hints for Audit search for
Ranger Audit Logs & Policy Search on Policy Listing Page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54054/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.
Bugs: RANGER-1227
https://issues.apache.org/jira/browse/RANGER-1227
Repository: ranger
Description
-------
Need to have UI Hints for search boxes that are presented on Reports page, Policy listing page and Audit page. UI hints will be helpful for new users to filter results as per their requirements.
Diffs
-----
security-admin/src/main/webapp/scripts/utils/XAUtils.js a1915cf
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 5b7f584
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 023dcc8
security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 0e2401e
security-admin/src/main/webapp/styles/xa.css 1eb7b6e
security-admin/src/main/webapp/templates/policies/RangerPolicyTableLayout_tmpl.html bde6b37
security-admin/src/main/webapp/templates/reports/AuditLayout_tmpl.html 48467aa
security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html df7acfb
Diff: https://reviews.apache.org/r/54054/diff/
Testing
-------
Verified UI hints working properly on Chrome.
Added UI hints for :
Policy Listing page
Reports page
Access Audit tab
Thanks,
Mehul Parikh
Re: Review Request 54054: RANGER-1227 : UI hints for Audit search for
Ranger Audit Logs & Policy Search on Policy Listing Page
Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54054/#review157002
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On Nov. 25, 2016, 12:15 p.m., Mehul Parikh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54054/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2016, 12:15 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1227
> https://issues.apache.org/jira/browse/RANGER-1227
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Need to have UI Hints for search boxes that are presented on Reports page, Policy listing page and Audit page. UI hints will be helpful for new users to filter results as per their requirements.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 786d08f
> security-admin/src/main/webapp/scripts/utils/XAUtils.js a1915cf
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 5b7f584
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 023dcc8
> security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 0e2401e
> security-admin/src/main/webapp/styles/xa.css 1eb7b6e
> security-admin/src/main/webapp/templates/policies/RangerPolicyTableLayout_tmpl.html bde6b37
> security-admin/src/main/webapp/templates/reports/AuditLayout_tmpl.html 48467aa
> security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html df7acfb
>
> Diff: https://reviews.apache.org/r/54054/diff/
>
>
> Testing
> -------
>
> Verified UI hints working properly on Chrome.
> Added UI hints for :
> Policy Listing page
> Reports page
> Access Audit tab
>
>
> Thanks,
>
> Mehul Parikh
>
>
Re: Review Request 54054: RANGER-1227 : UI hints for Audit search for
Ranger Audit Logs & Policy Search on Policy Listing Page
Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54054/
-----------------------------------------------------------
(Updated Nov. 25, 2016, 12:15 p.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.
Bugs: RANGER-1227
https://issues.apache.org/jira/browse/RANGER-1227
Repository: ranger
Description
-------
Need to have UI Hints for search boxes that are presented on Reports page, Policy listing page and Audit page. UI hints will be helpful for new users to filter results as per their requirements.
Diffs (updated)
-----
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 786d08f
security-admin/src/main/webapp/scripts/utils/XAUtils.js a1915cf
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 5b7f584
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 023dcc8
security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 0e2401e
security-admin/src/main/webapp/styles/xa.css 1eb7b6e
security-admin/src/main/webapp/templates/policies/RangerPolicyTableLayout_tmpl.html bde6b37
security-admin/src/main/webapp/templates/reports/AuditLayout_tmpl.html 48467aa
security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html df7acfb
Diff: https://reviews.apache.org/r/54054/diff/
Testing
-------
Verified UI hints working properly on Chrome.
Added UI hints for :
Policy Listing page
Reports page
Access Audit tab
Thanks,
Mehul Parikh
Re: Review Request 54054: RANGER-1227 : UI hints for Audit search for
Ranger Audit Logs & Policy Search on Policy Listing Page
Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54054/
-----------------------------------------------------------
(Updated Nov. 25, 2016, 11:58 a.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.
Bugs: RANGER-1227
https://issues.apache.org/jira/browse/RANGER-1227
Repository: ranger
Description
-------
Need to have UI Hints for search boxes that are presented on Reports page, Policy listing page and Audit page. UI hints will be helpful for new users to filter results as per their requirements.
Diffs (updated)
-----
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 786d08f
security-admin/src/main/webapp/scripts/utils/XAUtils.js a1915cf
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 5b7f584
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 023dcc8
security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 0e2401e
security-admin/src/main/webapp/styles/xa.css 1eb7b6e
security-admin/src/main/webapp/templates/policies/RangerPolicyTableLayout_tmpl.html bde6b37
security-admin/src/main/webapp/templates/reports/AuditLayout_tmpl.html 48467aa
security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html df7acfb
Diff: https://reviews.apache.org/r/54054/diff/
Testing
-------
Verified UI hints working properly on Chrome.
Added UI hints for :
Policy Listing page
Reports page
Access Audit tab
Thanks,
Mehul Parikh
Re: Review Request 54054: RANGER-1227 : UI hints for Audit search for
Ranger Audit Logs & Policy Search on Policy Listing Page
Posted by Nitin Galave <ni...@gmail.com>.
> On Nov. 24, 2016, 9:38 a.m., Gautam Borad wrote:
> > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js, line 324
> > <https://reviews.apache.org/r/54054/diff/1/?file=1569755#file1569755line324>
> >
> > Is removing the XAUtil.capitaliseFirstLetter(resource.name) intentional?
Yes.Service definition already contain label information about the resource field(contain capitalize form of label). So no need to capitalize.
- Nitin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54054/#review156824
-----------------------------------------------------------
On Nov. 24, 2016, 7:29 a.m., Mehul Parikh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54054/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2016, 7:29 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1227
> https://issues.apache.org/jira/browse/RANGER-1227
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Need to have UI Hints for search boxes that are presented on Reports page, Policy listing page and Audit page. UI hints will be helpful for new users to filter results as per their requirements.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/utils/XAUtils.js a1915cf
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 5b7f584
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 023dcc8
> security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 0e2401e
> security-admin/src/main/webapp/styles/xa.css 1eb7b6e
> security-admin/src/main/webapp/templates/policies/RangerPolicyTableLayout_tmpl.html bde6b37
> security-admin/src/main/webapp/templates/reports/AuditLayout_tmpl.html 48467aa
> security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html df7acfb
>
> Diff: https://reviews.apache.org/r/54054/diff/
>
>
> Testing
> -------
>
> Verified UI hints working properly on Chrome.
> Added UI hints for :
> Policy Listing page
> Reports page
> Access Audit tab
>
>
> Thanks,
>
> Mehul Parikh
>
>
Re: Review Request 54054: RANGER-1227 : UI hints for Audit search for
Ranger Audit Logs & Policy Search on Policy Listing Page
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54054/#review156824
-----------------------------------------------------------
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js (line 323)
<https://reviews.apache.org/r/54054/#comment227142>
Is removing the XAUtil.capitaliseFirstLetter(resource.name) intentional?
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js (line 344)
<https://reviews.apache.org/r/54054/#comment227143>
See above comment.
- Gautam Borad
On Nov. 24, 2016, 7:29 a.m., Mehul Parikh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54054/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2016, 7:29 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1227
> https://issues.apache.org/jira/browse/RANGER-1227
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Need to have UI Hints for search boxes that are presented on Reports page, Policy listing page and Audit page. UI hints will be helpful for new users to filter results as per their requirements.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/utils/XAUtils.js a1915cf
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 5b7f584
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 023dcc8
> security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 0e2401e
> security-admin/src/main/webapp/styles/xa.css 1eb7b6e
> security-admin/src/main/webapp/templates/policies/RangerPolicyTableLayout_tmpl.html bde6b37
> security-admin/src/main/webapp/templates/reports/AuditLayout_tmpl.html 48467aa
> security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html df7acfb
>
> Diff: https://reviews.apache.org/r/54054/diff/
>
>
> Testing
> -------
>
> Verified UI hints working properly on Chrome.
> Added UI hints for :
> Policy Listing page
> Reports page
> Access Audit tab
>
>
> Thanks,
>
> Mehul Parikh
>
>