You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/03/15 09:11:57 UTC
[GitHub] [calcite] korlov42 commented on a change in pull request #2623: CALCITE-4913 Correlated variables in a select list are not deduplicated
korlov42 commented on a change in pull request #2623:
URL: https://github.com/apache/calcite/pull/2623#discussion_r826736499
##########
File path: core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcRules.java
##########
@@ -544,7 +547,9 @@ public JdbcProject(RelOptCluster cluster, RelTraitSet traitSet,
}
@Override public JdbcProject copy(RelTraitSet traitSet, RelNode input,
- List<RexNode> projects, RelDataType rowType) {
+ List<RexNode> projects, RelDataType rowType, Set<CorrelationId> variablesSet) {
+ Preconditions.checkArgument(variablesSet.isEmpty(),
+ "Correlated scalar subqueries is not supported");
Review comment:
done
##########
File path: core/src/main/java/org/apache/calcite/interpreter/Bindables.java
##########
@@ -403,12 +405,14 @@ protected BindableProjectRule(Config config) {
public static class BindableProject extends Project implements BindableRel {
public BindableProject(RelOptCluster cluster, RelTraitSet traitSet,
RelNode input, List<? extends RexNode> projects, RelDataType rowType) {
- super(cluster, traitSet, ImmutableList.of(), input, projects, rowType);
+ super(cluster, traitSet, ImmutableList.of(), input, projects, rowType, ImmutableSet.of());
assert getConvention() instanceof BindableConvention;
}
@Override public BindableProject copy(RelTraitSet traitSet, RelNode input,
- List<RexNode> projects, RelDataType rowType) {
+ List<RexNode> projects, RelDataType rowType, Set<CorrelationId> variablesSet) {
+ Preconditions.checkArgument(variablesSet.isEmpty(),
+ "Correlated scalar subqueries is not supported");
Review comment:
done
##########
File path: cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraProject.java
##########
@@ -42,13 +46,15 @@
public class CassandraProject extends Project implements CassandraRel {
public CassandraProject(RelOptCluster cluster, RelTraitSet traitSet,
RelNode input, List<? extends RexNode> projects, RelDataType rowType) {
- super(cluster, traitSet, ImmutableList.of(), input, projects, rowType);
+ super(cluster, traitSet, ImmutableList.of(), input, projects, rowType, ImmutableSet.of());
assert getConvention() == CassandraRel.CONVENTION;
assert getConvention() == input.getConvention();
}
@Override public Project copy(RelTraitSet traitSet, RelNode input,
- List<RexNode> projects, RelDataType rowType) {
+ List<RexNode> projects, RelDataType rowType, Set<CorrelationId> variablesSet) {
+ Preconditions.checkArgument(variablesSet.isEmpty(),
+ "Correlated scalar subqueries is not supported");
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org