You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/07/11 00:42:41 UTC
[GitHub] [kafka] ableegoldman commented on a change in pull request #9010: KAFKA-10262: Ensure that creating task directory is thread safe
ableegoldman commented on a change in pull request #9010:
URL: https://github.com/apache/kafka/pull/9010#discussion_r453132871
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##########
@@ -47,10 +47,10 @@
public class StateDirectory {
private static final Pattern PATH_NAME = Pattern.compile("\\d+_\\d+");
-
- static final String LOCK_FILE_NAME = ".lock";
private static final Logger log = LoggerFactory.getLogger(StateDirectory.class);
+ static final String LOCK_FILE_NAME = ".lock";
+ private final Object taskCreationLock = new Object();
Review comment:
super nit: taskCreationLock --> taskDirCreationLock
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org