You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/05 03:28:43 UTC

[GitHub] [pulsar] mattisonchao commented on pull request #13611: [ Issue 13479 ] Fixed internal topic effect by InactiveTopicPolicy.

mattisonchao commented on pull request #13611:
URL: https://github.com/apache/pulsar/pull/13611#issuecomment-1005352599


   @codelipenghui  @ericsyh @eolivelli @BewareMyPower 
   
   PTAL :) 
   
   **Another things:**
   
   Although this PR can fix the issue #13479,  But I have some advice as below:
   
   1. ``healthcheck`` keyword name is common , maybe we can change this to some complex name.
   2. I think we can collect all internal or system theme names into one container, because they are currently everywhere. Unclear and difficult to maintain.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org