You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/10/01 11:09:27 UTC
[GitHub] [hadoop-ozone] elek opened a new pull request #1464: HDDS-4299. Display Ratis version with ozone version
elek opened a new pull request #1464:
URL: https://github.com/apache/hadoop-ozone/pull/1464
## What changes were proposed in this pull request?
During the development Ozone uses snapshot releases from Ratis. It can be useful to print out the exact version of the used Ratis as part of the output of "ozone version".
Ratis versions are part of the jar files since RATIS-1050
It can make the testing easier, as it's easier to check which Ratis version is used.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4299
## How was this patch tested?
```
./bin/ozone version
//////////////
////////////////////
//////// ////////////////
////// ////////////////
///// //////////////// /
///// //////// ///
//// //////// /////
///// ////////////////
///// //////////////// //
//// /////////////// /////
///// /////////////// ////
///// ////// /////
////// ////// /////
/////////// ////////
////// ////////////
/// //////////
/ 1.1.0-SNAPSHOT(Denali)
Source code repository git@github.com:apache/hadoop-ozone.git -r b2c6c3b61572bfd9b765f106ab2cf501db55e5e8
Compiled by elek on 2020-10-01T10:35Z
Compiled with protoc 2.5.0
From source with checksum ff92fd89808d10a6ee1dc21db8276427
With Apache Ratis: 1.1.0-11689cd-SNAPSHOT from 11689cd536b05bde323c9c6c6b57a8e82a60b680
Using HDDS 1.1.0-SNAPSHOT
Source code repository git@github.com:apache/hadoop-ozone.git -r b2c6c3b61572bfd9b765f106ab2cf501db55e5e8
Compiled by elek on 2020-10-01T10:34Z
Compiled with protoc 2.5.0
From source with checksum d0e6e752e4d52fb0f05063e16ade73d7
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1464: HDDS-4299. Display Ratis version with ozone version
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1464:
URL: https://github.com/apache/hadoop-ozone/pull/1464#issuecomment-703572792
Thanks @elek for the contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1464: HDDS-4299. Display Ratis version with ozone version
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1464:
URL: https://github.com/apache/hadoop-ozone/pull/1464#discussion_r498323795
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/RatisVersionInfo.java
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hdds.utils;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.Properties;
+
+import org.apache.hadoop.util.ThreadUtil;
+
+import org.slf4j.LoggerFactory;
+
+/**
+ * This class returns build information about Ratis projects.
+ */
+public class RatisVersionInfo {
+
+ private static final String RATIS_VERSION_PROPERTIES =
+ "ratis-version.properties";
+
+ private final Properties info = new Properties();
+
+ public RatisVersionInfo() {
+ try (InputStream is = ThreadUtil.getResourceAsStream(
+ getClass().getClassLoader(),
+ RATIS_VERSION_PROPERTIES)) {
+ info.load(is);
+ } catch (IOException ex) {
+ LoggerFactory.getLogger(getClass()).warn("Could not read '" +
+ RATIS_VERSION_PROPERTIES, ex);
Review comment:
```suggestion
LoggerFactory.getLogger(getClass()).warn("Could not read " +
RATIS_VERSION_PROPERTIES, ex);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai merged pull request #1464: HDDS-4299. Display Ratis version with ozone version
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #1464:
URL: https://github.com/apache/hadoop-ozone/pull/1464
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org