You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/06/21 06:50:00 UTC

[jira] [Commented] (KYLIN-4012) optimize cache in TrieDictionary/TrieDictionaryForest

    [ https://issues.apache.org/jira/browse/KYLIN-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16869243#comment-16869243 ] 

ASF GitHub Bot commented on KYLIN-4012:
---------------------------------------

jiezouSH commented on pull request #706:  KYLIN-4012 optimize cache in TrieDictionary/TrieDictionaryForest
URL: https://github.com/apache/kylin/pull/706
 
 
   KYLIN-4012 optimize cache in TrieDictionary/TrieDictionaryForest
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> optimize cache in TrieDictionary/TrieDictionaryForest
> -----------------------------------------------------
>
>                 Key: KYLIN-4012
>                 URL: https://issues.apache.org/jira/browse/KYLIN-4012
>             Project: Kylin
>          Issue Type: Improvement
>    Affects Versions: v2.5.0
>            Reporter: jiezouSH
>            Assignee: jiezouSH
>            Priority: Major
>
> Currently, 
> CacheDictionary, parent class of TrieDictionary and TrieDictionaryForest, has 3 cache: 
> valueToIdCache, 
> idToValueCache, 
> idToValueByteCache.
> However, The function of idToValueCache and idToValueByteCache is highly duplicated.
> It is better to merge idToValueCache and idToValueByteCache, saving memory in about half the dict's physical size



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)