You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2016/07/13 12:06:27 UTC

[GitHub] flink pull request #2238: [FLINK-3729] Fix Several SQL tests on Windows OS 

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/2238

    [FLINK-3729] Fix Several SQL tests on Windows OS 

    - fixed ExplainTest by replacing all occurrences of `\r\n` with `\n` before comparing the output
    - replaced usages of `\n` in BatchTableEnvironment#explain() with System.lineSeparator
    - fixed TableSinkITCase by generating the qualidifed path using `File#toUri()` and `URI#toString()`
    - removed a lot of unused imports in TableSinkITCase

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 3729_sql_tests_windows

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2238.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2238
    
----
commit 0694fde595289b4ae145544fb39598fee63e8bf5
Author: zentol <ch...@apache.org>
Date:   2016-07-13T11:51:05Z

    [FLINK-3729][table] Fix ExplainTest on Windows OS

commit d79866a78b30d6794c6c96431ac53d6a5119890d
Author: zentol <ch...@apache.org>
Date:   2016-07-13T11:51:34Z

    [FLINK-3729][table] Fix TableSinkITCase on Windows OS

commit 31c121c25cae70262c0187e43b41a144a326ab33
Author: zentol <ch...@apache.org>
Date:   2016-07-13T11:51:53Z

    [hotfix][table] Remove unused imports in TableSinkITCase

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2238: [FLINK-3729] Fix Several SQL tests on Windows OS

Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/2238
  
    LGTM. I will merge it. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2238: [FLINK-3729] Fix Several SQL tests on Windows OS

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/2238


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---