[GitHub] [thrift] emmenlau commented on a diff in pull request #2732: THRIFT-5670: Fix wrong usage of GlobalOutput.perror()

[GitBox <gi...@apache.org>]

emmenlau commented on code in PR #2732:
URL: https://github.com/apache/thrift/pull/2732#discussion_r1034993931


##########
lib/cpp/src/thrift/transport/TSocket.cpp:
##########
@@ -569,7 +569,7 @@ uint32_t TSocket::read(uint8_t* buf, uint32_t len) {
         throw TTransportException(TTransportException::INTERRUPTED, "Interrupted");
       }
     } else /* ret == 0 */ {
-      GlobalOutput.perror("TSocket::read() THRIFT_EAGAIN (timed out) after %f ms", recvTimeout_);
+      GlobalOutput.printf("TSocket::read() THRIFT_EAGAIN (timed out) after %d ms", recvTimeout_);

Review Comment:
   Dear @stiga-huang can you kindly help me understand why `printf` is better here than `perror`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org