[jira] [Closed] (JEXL-189) Possible bug in Interpreter.isCancelled()

["Henri Biestro (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/JEXL-189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Biestro closed JEXL-189.
------------------------------

> Possible bug in Interpreter.isCancelled()
> -----------------------------------------
>
>                 Key: JEXL-189
>                 URL: https://issues.apache.org/jira/browse/JEXL-189
>             Project: Commons JEXL
>          Issue Type: Bug
>    Affects Versions: 3.0
>            Reporter: Dmitri Blinov
>            Assignee: Henri Biestro
>            Priority: Trivial
>             Fix For: 3.1
>
>
> Reported by FindBugs is the message: 
> "Questionable use of non-short-circuit logic in org.apache.commons.jexl3.internal.Interpreter.isCancelled()"
> {code}
>     protected boolean isCancelled() {
>         if (cancelled | Thread.interrupted()) {
>             cancelled = true;
>         }
>         return cancelled;
>     }
> {\code}
> Maybe it is better to replace method as 
> {code}
>     protected boolean isCancelled() {
>         if (Thread.interrupted())
>             cancelled = true;
>         return cancelled;
>     }
> {\code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)