You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/12/26 17:45:10 UTC

[GitHub] [pinot] KKcorps commented on a change in pull request #7960: Re-enable kinesis test

KKcorps commented on a change in pull request #7960:
URL: https://github.com/apache/pinot/pull/7960#discussion_r775268735



##########
File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/RealtimeKinesisIntegrationTest.java
##########
@@ -83,8 +85,8 @@
 import software.amazon.awssdk.utils.AttributeMap;
 
 
-@LocalstackDockerProperties(services = {"kinesis"})
-@Test(enabled = false)
+@LocalstackDockerProperties(services = {ServiceName.KINESIS}, portEdge = "4591", environmentVariableProvider = RealtimeKinesisIntegrationTest.HostnameEnvProvider.class, imageTag = "0.13.0.10")

Review comment:
       Hi, @xiangfu0 don't review this PR yet. it is still WIP. this kinesis issue is not reproducible in my local and any other VMs I created. So I raised this PR just to test out what is going wrong.
   Will fix linting once I have a working solution.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org