You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/23 21:39:00 UTC

[GitHub] [arrow] kou commented on a diff in pull request #14351: ARROW-17904: [C++] [WIP] Parquet Implement crc in reading and writing Page for DATA_PAGE (v1)

kou commented on code in PR #14351:
URL: https://github.com/apache/arrow/pull/14351#discussion_r1002776531


##########
cpp/src/arrow/util/crc32.cc:
##########
@@ -0,0 +1,961 @@
+// Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   Could you put this to `cpp/src/arrow/vendored/crc32.c` (or `crc32.cc`?) like `cpp/src/arrow/vendored/base64.cpp`?
   We can update vendored code easily by reusing the original code as much as possible.
   
   Could you also add an entry for `crc32.c` to `LICENSE.txt`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org