You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Olga Smola <ol...@gmail.com> on 2012/06/27 14:57:17 UTC
Review Request: CS-15349: UI Incorrect result when Make owner in New
project/Add account.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5615/
-----------------------------------------------------------
Review request for cloudstack and Brian Federle.
Description
-------
Fix for http://bugs.cloudstack.org/browse/CS-15349
Could you please also take a look at http://bugs.cloudstack.org/browse/CS-15317 (on review https://reviews.apache.org/r/5574/ ), ticket is too closed to the current one.
This addresses bug CS-15349.
Diffs
-----
ui/scripts/projects.js 6a99939
ui/scripts/ui/widgets/multiEdit.js 0481dda
Diff: https://reviews.apache.org/r/5615/diff/
Testing
-------
Thanks,
Olga Smola
Re: Review Request: CS-15349: UI Incorrect result when Make owner in New
project/Add account.
Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5615/#review8979
-----------------------------------------------------------
A few small modifications:
-If the project owner is changed in the wizard, trigger a fullRefresh event so that the project list view is updated with the new owner
-Rename the 'allowOwnerActions' option in the multiEdit widget to 'disableEditCheck' (or 'readOnlyCheck' or something like that), this is just for clarity since it needs to be a generic function that can be utilized in other cases.
- Brian Federle
On June 27, 2012, 12:57 p.m., Olga Smola wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5615/
> -----------------------------------------------------------
>
> (Updated June 27, 2012, 12:57 p.m.)
>
>
> Review request for cloudstack and Brian Federle.
>
>
> Description
> -------
>
> Fix for http://bugs.cloudstack.org/browse/CS-15349
> Could you please also take a look at http://bugs.cloudstack.org/browse/CS-15317 (on review https://reviews.apache.org/r/5574/ ), ticket is too closed to the current one.
>
>
> This addresses bug CS-15349.
>
>
> Diffs
> -----
>
> ui/scripts/projects.js 6a99939
> ui/scripts/ui/widgets/multiEdit.js 0481dda
>
> Diff: https://reviews.apache.org/r/5615/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Olga Smola
>
>
Re: Review Request: CS-15349: UI Incorrect result when Make owner in New
project/Add account.
Posted by Olga Smola <ol...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5615/
-----------------------------------------------------------
(Updated July 11, 2012, 7:58 a.m.)
Review request for cloudstack and Brian Federle.
Changes
-------
- Added trigger "fullRefresh" after change owner
- Renamed 'allowOwnerActions' to 'readOnlyCheck' to be more clear
Description
-------
Fix for http://bugs.cloudstack.org/browse/CS-15349
Could you please also take a look at http://bugs.cloudstack.org/browse/CS-15317 (on review https://reviews.apache.org/r/5574/ ), ticket is too closed to the current one.
This addresses bug CS-15349.
Diffs (updated)
-----
ui/scripts/projects.js 6a99939
ui/scripts/ui/widgets/multiEdit.js 0481dda
Diff: https://reviews.apache.org/r/5615/diff/
Testing
-------
Thanks,
Olga Smola
Re: Review Request: CS-15349: UI Incorrect result when Make owner in New
project/Add account.
Posted by Olga Smola <ol...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5615/
-----------------------------------------------------------
(Updated June 27, 2012, 12:57 p.m.)
Review request for cloudstack and Brian Federle.
Description
-------
Fix for http://bugs.cloudstack.org/browse/CS-15349
Could you please also take a look at http://bugs.cloudstack.org/browse/CS-15317 (on review https://reviews.apache.org/r/5574/ ), ticket is too closed to the current one.
This addresses bug CS-15349.
Diffs
-----
ui/scripts/projects.js 6a99939
ui/scripts/ui/widgets/multiEdit.js 0481dda
Diff: https://reviews.apache.org/r/5615/diff/
Testing
-------
Thanks,
Olga Smola