[GitHub] [hive] kgyrtkirk commented on pull request #1205: HIVE-23800: Add hooks when HiveServer2 stops due to OutOfMemoryError

[GitBox <gi...@apache.org>]

kgyrtkirk commented on pull request #1205:
URL: https://github.com/apache/hive/pull/1205#issuecomment-658002425


   when I was using some of these hooks earlier: they are too specific to some purpose.
   right now the proposed callback is a {{Runnable}} ... which means you will have to create a completely new one in case you want to pass some things to it later...
   
   so...I would recommend the following:
   * remove the "oom" keyword from the name of the hook/etc - it could be diag, debug or something like that
   * add a callback which has 2 arguments:
     * a callback type (some enum; which should have a value which is specific to "oom")
     * some callback payload object to which we can add things later on... it could be an object using the {{Adaptable}} pattern
   
   all this stuff is to make it a bit more reusable if we need to reuse it later on...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org