You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jared Stewart <js...@pivotal.io> on 2017/05/01 20:43:27 UTC
Review Request 58891: GEODE-2837: Start server creates specified
working dir if necessary
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58891/
-----------------------------------------------------------
Review request for geode, Jinmei Liao, Ken Howe, Kirk Lund, and Patrick Rhomberg.
Repository: geode
Description
-------
GEODE-2837: Start server creates specified working dir if necessary
Diffs
-----
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java b51505acde785582801920007eec7e38d2a0029d
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 0e681d725be25a4a8d9e5aa98d289ae07db8af55
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java a793235b45618bc4c95b56191f8c93712a8f7675
Diff: https://reviews.apache.org/r/58891/diff/1/
Testing
-------
Precheckin started (still running)
Thanks,
Jared Stewart
Re: Review Request 58891: GEODE-2837: Start server creates specified
working dir if necessary
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58891/#review173551
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On May 1, 2017, 10:16 p.m., Jared Stewart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58891/
> -----------------------------------------------------------
>
> (Updated May 1, 2017, 10:16 p.m.)
>
>
> Review request for geode, Jinmei Liao, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2837: Start server creates specified working dir if necessary
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java b51505a
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 0e681d7
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java a793235
>
>
> Diff: https://reviews.apache.org/r/58891/diff/2/
>
>
> Testing
> -------
>
> Precheckin started (still running)
>
>
> Thanks,
>
> Jared Stewart
>
>
Re: Review Request 58891: GEODE-2837: Start server creates specified
working dir if necessary
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58891/
-----------------------------------------------------------
(Updated May 2, 2017, 4:03 p.m.)
Review request for geode, Jinmei Liao, Ken Howe, Kirk Lund, and Patrick Rhomberg.
Repository: geode
Description
-------
GEODE-2837: Start server creates specified working dir if necessary
Diffs
-----
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java b51505a
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 0e681d7
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java a793235
Diff: https://reviews.apache.org/r/58891/diff/2/
Testing (updated)
-------
Precheckin passed
Thanks,
Jared Stewart
Re: Review Request 58891: GEODE-2837: Start server creates specified
working dir if necessary
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58891/
-----------------------------------------------------------
(Updated May 1, 2017, 10:16 p.m.)
Review request for geode, Jinmei Liao, Ken Howe, Kirk Lund, and Patrick Rhomberg.
Changes
-------
Added test to verify behavior when the working dir is specified as a relative path.
Repository: geode
Description
-------
GEODE-2837: Start server creates specified working dir if necessary
Diffs (updated)
-----
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java b51505a
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 0e681d7
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java a793235
Diff: https://reviews.apache.org/r/58891/diff/2/
Changes: https://reviews.apache.org/r/58891/diff/1-2/
Testing
-------
Precheckin started (still running)
Thanks,
Jared Stewart
Re: Review Request 58891: GEODE-2837: Start server creates specified
working dir if necessary
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58891/#review173513
-----------------------------------------------------------
According to the documentation on this --dir: Specify the directory in which the server will run in. This directory is written to the location where you started. It sounds like this dir needs to be a relative path and always under where gfsh is started. Not sure if this is the case after your fix.
Probably add a test where you specify a relative path and make sure it's created under where gfsh started?
- Jinmei Liao
On May 1, 2017, 8:43 p.m., Jared Stewart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58891/
> -----------------------------------------------------------
>
> (Updated May 1, 2017, 8:43 p.m.)
>
>
> Review request for geode, Jinmei Liao, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2837: Start server creates specified working dir if necessary
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java b51505acde785582801920007eec7e38d2a0029d
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 0e681d725be25a4a8d9e5aa98d289ae07db8af55
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java a793235b45618bc4c95b56191f8c93712a8f7675
>
>
> Diff: https://reviews.apache.org/r/58891/diff/1/
>
>
> Testing
> -------
>
> Precheckin started (still running)
>
>
> Thanks,
>
> Jared Stewart
>
>