You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinson Lee <vl...@freedesktop.org> on 2014/01/15 18:40:23 UTC
Review Request 16909: Require libc++ only on Mac OS X.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16909/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Eric Biederman, samya, and Vinod Kone.
Repository: mesos-git
Description
-------
From: Vinson Lee <vl...@twitter.com>
Date: Wed, 15 Jan 2014 09:31:04 -0800
Subject: [PATCH] Require libc++ only on Mac OS X.
Signed-off-by: Vinson Lee <vl...@twitter.com>
Diffs
-----
configure.ac 9f96b7d
Diff: https://reviews.apache.org/r/16909/diff/
Testing
-------
On Linux:
$ ./bootstrap
$ ./configure
Thanks,
Vinson Lee
Re: Review Request 16909: Require libc++ only on Mac OS X.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16909/#review31888
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Jan. 15, 2014, 6:08 p.m., Vinson Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16909/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 6:08 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Eric Biederman, samya, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> From: Vinson Lee <vl...@twitter.com>
> Date: Wed, 15 Jan 2014 09:31:04 -0800
> Subject: [PATCH] Require libc++ only on Mac OS X.
>
> This patch fixes configure failure on Linux clang builds.
>
> Signed-off-by: Vinson Lee <vl...@twitter.com>
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac e461590
> configure.ac 9f96b7d
>
> Diff: https://reviews.apache.org/r/16909/diff/
>
>
> Testing
> -------
>
> On Linux:
> $ ./bootstrap
> $ ./configure
> $ make
>
> configure now passes again.
>
> Linux clang build now fails at symbolize.cc.
> src/symbolize.cc:235:58: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
> RAW_LOG(WARNING, "Section name '%s' is too long (%"PRIuS"); "
>
>
> Thanks,
>
> Vinson Lee
>
>
Re: Review Request 16909: Require libc++ only on Mac OS X.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16909/#review33888
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Jan. 15, 2014, 11:04 p.m., Vinson Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16909/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 11:04 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Eric Biederman, samya, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> From: Vinson Lee <vl...@twitter.com>
> Date: Wed, 15 Jan 2014 09:31:04 -0800
> Subject: [PATCH] Require libc++ only on Mac OS X.
>
> This patch fixes configure failure on Linux clang builds.
>
> Signed-off-by: Vinson Lee <vl...@twitter.com>
>
>
> Diffs
> -----
>
> configure.ac 9f96b7d
>
> Diff: https://reviews.apache.org/r/16909/diff/
>
>
> Testing
> -------
>
> On Linux:
> $ ./bootstrap
> $ ./configure
> $ make
>
> configure now passes again.
>
> Linux clang build now fails at symbolize.cc.
> src/symbolize.cc:235:58: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
> RAW_LOG(WARNING, "Section name '%s' is too long (%"PRIuS"); "
>
>
> Thanks,
>
> Vinson Lee
>
>
Re: Review Request 16909: Require libc++ only on Mac OS X.
Posted by Vinson Lee <vl...@freedesktop.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16909/
-----------------------------------------------------------
(Updated Jan. 15, 2014, 11:04 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Eric Biederman, samya, and Vinod Kone.
Changes
-------
Per Vinod Kone's comments, splitting out libprocess change into separate review.
Repository: mesos-git
Description
-------
From: Vinson Lee <vl...@twitter.com>
Date: Wed, 15 Jan 2014 09:31:04 -0800
Subject: [PATCH] Require libc++ only on Mac OS X.
This patch fixes configure failure on Linux clang builds.
Signed-off-by: Vinson Lee <vl...@twitter.com>
Diffs (updated)
-----
configure.ac 9f96b7d
Diff: https://reviews.apache.org/r/16909/diff/
Testing
-------
On Linux:
$ ./bootstrap
$ ./configure
$ make
configure now passes again.
Linux clang build now fails at symbolize.cc.
src/symbolize.cc:235:58: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
RAW_LOG(WARNING, "Section name '%s' is too long (%"PRIuS"); "
Thanks,
Vinson Lee
Re: Review Request 16909: Require libc++ only on Mac OS X.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16909/#review31889
-----------------------------------------------------------
Would you mind splitting the libprocess change into its own review? Thats been our standard practice.
- Vinod Kone
On Jan. 15, 2014, 6:08 p.m., Vinson Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16909/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 6:08 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Eric Biederman, samya, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> From: Vinson Lee <vl...@twitter.com>
> Date: Wed, 15 Jan 2014 09:31:04 -0800
> Subject: [PATCH] Require libc++ only on Mac OS X.
>
> This patch fixes configure failure on Linux clang builds.
>
> Signed-off-by: Vinson Lee <vl...@twitter.com>
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac e461590
> configure.ac 9f96b7d
>
> Diff: https://reviews.apache.org/r/16909/diff/
>
>
> Testing
> -------
>
> On Linux:
> $ ./bootstrap
> $ ./configure
> $ make
>
> configure now passes again.
>
> Linux clang build now fails at symbolize.cc.
> src/symbolize.cc:235:58: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
> RAW_LOG(WARNING, "Section name '%s' is too long (%"PRIuS"); "
>
>
> Thanks,
>
> Vinson Lee
>
>
Re: Review Request 16909: Require libc++ only on Mac OS X.
Posted by Vinson Lee <vl...@freedesktop.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16909/
-----------------------------------------------------------
(Updated Jan. 15, 2014, 6:08 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Eric Biederman, samya, and Vinod Kone.
Repository: mesos-git
Description (updated)
-------
From: Vinson Lee <vl...@twitter.com>
Date: Wed, 15 Jan 2014 09:31:04 -0800
Subject: [PATCH] Require libc++ only on Mac OS X.
This patch fixes configure failure on Linux clang builds.
Signed-off-by: Vinson Lee <vl...@twitter.com>
Diffs
-----
3rdparty/libprocess/configure.ac e461590
configure.ac 9f96b7d
Diff: https://reviews.apache.org/r/16909/diff/
Testing (updated)
-------
On Linux:
$ ./bootstrap
$ ./configure
$ make
configure now passes again.
Linux clang build now fails at symbolize.cc.
src/symbolize.cc:235:58: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
RAW_LOG(WARNING, "Section name '%s' is too long (%"PRIuS"); "
Thanks,
Vinson Lee
Re: Review Request 16909: Require libc++ only on Mac OS X.
Posted by Vinson Lee <vl...@freedesktop.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16909/
-----------------------------------------------------------
(Updated Jan. 15, 2014, 6:07 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Eric Biederman, samya, and Vinod Kone.
Changes
-------
Added equivalent change to 3rdparty/libprocess/configure.ac.
Repository: mesos-git
Description
-------
From: Vinson Lee <vl...@twitter.com>
Date: Wed, 15 Jan 2014 09:31:04 -0800
Subject: [PATCH] Require libc++ only on Mac OS X.
Signed-off-by: Vinson Lee <vl...@twitter.com>
Diffs (updated)
-----
3rdparty/libprocess/configure.ac e461590
configure.ac 9f96b7d
Diff: https://reviews.apache.org/r/16909/diff/
Testing
-------
On Linux:
$ ./bootstrap
$ ./configure
Thanks,
Vinson Lee