You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/05 16:17:06 UTC

[GitHub] [spark] kuwii commented on pull request #35356: [SPARK-38056][Web UI] Fix issue of Structured streaming not working in history server when using LevelDB

kuwii commented on pull request #35356:
URL: https://github.com/apache/spark/pull/35356#issuecomment-1030652661


   > The newly added test case fails on Apple Silicon environment.
   > 
   > Please add the following at `test("SPARK-38056: test writing StreamingQueryData to a LevelDB store")`.
   > 
   > ```scala
   > assume(!Utils.isMacOnAppleSilicon)
   > ```
   > 
   > In addition, we have multiple-backend and the test case has a default value assumption which the file-system backend is LevelDB. It will be broken when we change the default backend to RocksDB. Please remove the assumption by setting `HYBRID_STORE_DISK_BACKEND` explicitly.
   > 
   > (BTW, please note that both LevelDB and RocksDB doesn't work on Apple Silicon yet. RocksDB will fix it in this year)
   
   Code added in [f7b33655c29cfe18a2359a1e4292bf4896f584ed](https://github.com/apache/spark/pull/35356/commits/f7b33655c29cfe18a2359a1e4292bf4896f584ed), and moved to `StreamingQueryStatusListenserSuite`in [83f7cbb756f91f7ee7f4896d78d751dcfd25e9b5](https://github.com/apache/spark/pull/35356/commits/83f7cbb756f91f7ee7f4896d78d751dcfd25e9b5).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org