You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@roller.apache.org by GitBox <gi...@apache.org> on 2021/02/15 22:50:02 UTC

[GitHub] [roller] snoopdave commented on pull request #75: Ipbanlist fixes

snoopdave commented on pull request #75:
URL: https://github.com/apache/roller/pull/75#issuecomment-779481465


   > looks good, some remarks:
   > 
   > * volatile could be removed again if the Set is made final (and cleared + reused in loadBannedIps())
   > * loadBannedIpsIfNeeded is only called with forceLoad set to false -> opportunity to be simplified.
   > 
   > sidenote:
   > I noticed that the IPBanList is indirectly polling the modification time of the file via isBanned(). Maybe it could be polled only once per second? I don't know the exact requirements for this feature however. Maybe @snoopdave could help.
   
   Even once per second seems a bit excessive. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org