Re: [PR] feat(ci): add step to verify generated viz plugin [superset]

["mistercrunch (via GitHub)" <gi...@apache.org>]

mistercrunch commented on code in PR #33637:
URL: https://github.com/apache/superset/pull/33637#discussion_r2121798516


##########
superset-frontend/packages/generator-superset/generators/plugin-chart/templates/package.erb:
##########
@@ -28,17 +28,23 @@
   },
   "dependencies": {},
   "peerDependencies": {
-    "@airbnb/config-babel": "^2.0.1",
     "@superset-ui/chart-controls": "*",
     "@superset-ui/core": "*",
-    "react": "^17.0.2"
+    "antd-v5": "npm:antd@^5.18.0",

Review Comment:
   after the large refactor in the theming branch, it's likely we need to re-think / simplify plugin authoring, where now there's `@superset-ui/core/components` and no more antd-v4. I'm not against merging this but for sure will raise conflicts with the theming branch.
   
   In this phase I'd generally would advocate to spend cycles on rethinking some sort of `plugin-sdk/` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org