You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org> on 2018/03/16 19:37:19 UTC
Change in asterixdb-bad[master]: Add timeout to Broker connection for notifications
Steven Jacobs has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2497
Change subject: Add timeout to Broker connection for notifications
......................................................................
Add timeout to Broker connection for notifications
Change-Id: Ic2803bdba15e6742a084a84d483996ab7ab45a8e
---
M asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/97/2497/1
diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java b/asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
index 1db0669..41853b9 100644
--- a/asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
+++ b/asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
@@ -106,6 +106,7 @@
connection.setUseCaches(false);
connection.setDoOutput(true);
+ connection.setConnectTimeout(500);
if (connection.getOutputStream() != null) {
//Send message
@@ -113,7 +114,7 @@
wr.writeBytes(urlParameters);
wr.close();
} else {
- LOGGER.log(Level.WARNING, "Channel Failed to connect to Broker.");
+ throw new Exception();
}
if (LOGGER.isLoggable(Level.INFO)) {
--
To view, visit https://asterix-gerrit.ics.uci.edu/2497
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2803bdba15e6742a084a84d483996ab7ab45a8e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Change in asterixdb-bad[master]: Add timeout to Broker connection for notifications
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Add timeout to Broker connection for notifications
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/257/
--
To view, visit https://asterix-gerrit.ics.uci.edu/2497
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2803bdba15e6742a084a84d483996ab7ab45a8e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb-bad[master]: Add timeout to Broker connection for notifications
Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.
Steven Jacobs has submitted this change and it was merged.
Change subject: Add timeout to Broker connection for notifications
......................................................................
Add timeout to Broker connection for notifications
Change-Id: Ic2803bdba15e6742a084a84d483996ab7ab45a8e
---
M asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins: Verified
Xikui Wang: Looks good to me, approved
diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java b/asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
index 1db0669..41853b9 100644
--- a/asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
+++ b/asterix-bad/src/main/java/org/apache/asterix/bad/ChannelJobService.java
@@ -106,6 +106,7 @@
connection.setUseCaches(false);
connection.setDoOutput(true);
+ connection.setConnectTimeout(500);
if (connection.getOutputStream() != null) {
//Send message
@@ -113,7 +114,7 @@
wr.writeBytes(urlParameters);
wr.close();
} else {
- LOGGER.log(Level.WARNING, "Channel Failed to connect to Broker.");
+ throw new Exception();
}
if (LOGGER.isLoggable(Level.INFO)) {
--
To view, visit https://asterix-gerrit.ics.uci.edu/2497
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2803bdba15e6742a084a84d483996ab7ab45a8e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Xikui Wang <xk...@gmail.com>
Change in asterixdb-bad[master]: Add timeout to Broker connection for notifications
Posted by "Steven Jacobs (Code Review)" <do...@asterixdb.incubator.apache.org>.
Steven Jacobs has posted comments on this change.
Change subject: Add timeout to Broker connection for notifications
......................................................................
Patch Set 1:
With a valid broker URL it should not. I'll have Yusuf confirm.
--
To view, visit https://asterix-gerrit.ics.uci.edu/2497
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2803bdba15e6742a084a84d483996ab7ab45a8e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Xikui Wang <xk...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb-bad[master]: Add timeout to Broker connection for notifications
Posted by "Xikui Wang (Code Review)" <do...@asterixdb.incubator.apache.org>.
Xikui Wang has posted comments on this change.
Change subject: Add timeout to Broker connection for notifications
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/2497
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2803bdba15e6742a084a84d483996ab7ab45a8e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Xikui Wang <xk...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb-bad[master]: Add timeout to Broker connection for notifications
Posted by "Xikui Wang (Code Review)" <do...@asterixdb.incubator.apache.org>.
Xikui Wang has posted comments on this change.
Change subject: Add timeout to Broker connection for notifications
......................................................................
Patch Set 1:
This timeout should not happen right?
--
To view, visit https://asterix-gerrit.ics.uci.edu/2497
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2803bdba15e6742a084a84d483996ab7ab45a8e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sj...@ucr.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Xikui Wang <xk...@gmail.com>
Gerrit-HasComments: No