You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhuvanthi Radhakrishnan <mr...@hortonworks.com> on 2017/01/13 21:48:10 UTC

Review Request 55524: Add log rotation settings to Hive, Druid, Storm

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55524/
-----------------------------------------------------------

Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-19538
    https://issues.apache.org/jira/browse/AMBARI-19538


Repository: ambari


Description
-------

Add log rotation settings to Hive, Druid, Storm


Diffs
-----

  ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml f612766 
  ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py c83b16e 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-log4j.xml cc837bb 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-log4j.xml 96562df 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 58f01e6 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a515b62 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py aa116d6 
  ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-cluster-log4j.xml 58e1791 
  ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-worker-log4j.xml adf57fa 
  ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py c167d7c 
  ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-cluster-log4j.xml 1709f0d 
  ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-worker-log4j.xml a1029a2 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml 6953530 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py 2653254 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py bf9c208 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 6e97d15 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 2b26dd8 

Diff: https://reviews.apache.org/r/55524/diff/


Testing
-------

Verified log4j rotation changes:
UI
DB
API
Disk


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 55524: Add log rotation settings to Hive, Druid, Storm

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55524/#review161759
-----------------------------------------------------------


Ship it!




Ship It!

- Jayush Luniya


On Jan. 13, 2017, 9:48 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55524/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2017, 9:48 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19538
>     https://issues.apache.org/jira/browse/AMBARI-19538
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add log rotation settings to Hive, Druid, Storm
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml f612766 
>   ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py c83b16e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-log4j.xml cc837bb 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-log4j.xml 96562df 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 58f01e6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a515b62 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py aa116d6 
>   ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-cluster-log4j.xml 58e1791 
>   ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-worker-log4j.xml adf57fa 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py c167d7c 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-cluster-log4j.xml 1709f0d 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-worker-log4j.xml a1029a2 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml 6953530 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py 2653254 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py bf9c208 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 6e97d15 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 2b26dd8 
> 
> Diff: https://reviews.apache.org/r/55524/diff/
> 
> 
> Testing
> -------
> 
> Verified log4j rotation changes:
> UI
> DB
> API
> Disk
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 55524: Add log rotation settings to Hive, Druid, Storm

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55524/#review161605
-----------------------------------------------------------


Ship it!




Ship It!

- Sumit Mohanty


On Jan. 13, 2017, 9:48 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55524/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2017, 9:48 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19538
>     https://issues.apache.org/jira/browse/AMBARI-19538
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add log rotation settings to Hive, Druid, Storm
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml f612766 
>   ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py c83b16e 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-log4j.xml cc837bb 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-log4j.xml 96562df 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 58f01e6 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a515b62 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py aa116d6 
>   ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-cluster-log4j.xml 58e1791 
>   ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-worker-log4j.xml adf57fa 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py c167d7c 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-cluster-log4j.xml 1709f0d 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-worker-log4j.xml a1029a2 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml 6953530 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py 2653254 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py bf9c208 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 6e97d15 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 2b26dd8 
> 
> Diff: https://reviews.apache.org/r/55524/diff/
> 
> 
> Testing
> -------
> 
> Verified log4j rotation changes:
> UI
> DB
> API
> Disk
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>