You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "praveer38 (via GitHub)" <gi...@apache.org> on 2024/11/08 09:57:48 UTC

[I] Fullscreen mode: Unnecessary vertical scrollbar blocks UI elements on right side of screen [superset]

praveer38 opened a new issue, #30879:
URL: https://github.com/apache/superset/issues/30879

   ## Screenshot
   
   ![chrome_j5mjQOUXzT](https://github.com/user-attachments/assets/5663a0ec-9205-46a5-927d-ec2cd6e8372a)
   ![chrome_8UBAYWGVV9](https://github.com/user-attachments/assets/ea22dc76-904a-4b8f-93b5-025d55bb6b19)
   
   
   ## Description
   
   When a graph is in fullscreen mode, there is an unnecessary vertical scrollbar that blocks some of the UI elements on the right side of the screen (i.e. the “Inv” button).  This vertical scrollbar remains visible regardless of the browser window size.
   
   Expected: 
   
   The scrollbar should not be present. Even if the scrollbar is present, the buttons on the corner should not be affected the way they are getting hidden.
   
   Actual:
   
   The scrollbar is present and obscures some page elements under it
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Fullscreen mode: Unnecessary vertical scrollbar blocks UI elements on right side of screen [superset]

Posted by "samarsrivastav (via GitHub)" <gi...@apache.org>.
samarsrivastav commented on issue #30879:
URL: https://github.com/apache/superset/issues/30879#issuecomment-2466253348

   hey @praveer38 !! i have looked into the code and the issue, i think changing the padding of the chart in fullscreen mode will solve the issue 
   here is an screenshot of the code and the website-
   ![Screenshot 2024-11-09 at 8 43 00 PM](https://github.com/user-attachments/assets/a4eb072d-b9e1-4505-928f-37b1f2b06679)
   <img width="661" alt="Screenshot 2024-11-09 at 8 42 33 PM" src="https://github.com/user-attachments/assets/8298521e-5744-40dc-8845-0772e2e5331a">
   Please letme know your thoughts
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Fullscreen mode: Unnecessary vertical scrollbar blocks UI elements on right side of screen [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #30879: Fullscreen mode: Unnecessary vertical scrollbar blocks UI elements on right side of screen
URL: https://github.com/apache/superset/issues/30879


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Fullscreen mode: Unnecessary vertical scrollbar blocks UI elements on right side of screen [superset]

Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #30879:
URL: https://github.com/apache/superset/issues/30879#issuecomment-2464287282

   <!-- Answer -->
   The issue with the unnecessary vertical scrollbar in fullscreen mode could be related to the CSS styling applied to the chart or its container. The `ChartHolder` component uses a fixed position with a high z-index for fullscreen mode, which might be causing layout issues if the dimensions are not correctly calculated or if there is an overflow property set on the container or parent elements <sup>[[1]](https://github.com/apache/superset/blob/master/superset-frontend/src/dashboard/components/gridComponents/ChartHolder.tsx)</sup>.
   
   To address this, you can check the following:
   
   1. **CSS Overflow Property**: Ensure that there is no `overflow` property set to `auto` or `scroll` on the container or parent elements that might be causing the scrollbar to appear unnecessarily.
   
   2. **Chart Dimensions**: Verify that the chart's width and height are correctly set to the window's inner dimensions minus any margins. This can prevent the scrollbar from appearing if the chart is slightly larger than the viewport.
   
   3. **CSS Styles**: Review any additional CSS styles that might be affecting the layout in fullscreen mode, particularly those related to margins, padding, or positioning.
   
   Adjusting these aspects should help in resolving the issue with the scrollbar obscuring UI elements.
   
   
   <!-- Dosu Comment Footer -->
   *To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org