You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by jo...@apache.org on 2006/10/17 16:22:45 UTC
svn commit: r464930 - in /maven/plugins/trunk/maven-eclipse-plugin: pom.xml
src/main/java/org/apache/maven/plugin/eclipse/InstallPluginsMojo.java
Author: joakime
Date: Tue Oct 17 07:22:44 2006
New Revision: 464930
URL: http://svn.apache.org/viewvc?view=rev&rev=464930
Log:
Ensuring that codebase works with JDK 1.4
Modified:
maven/plugins/trunk/maven-eclipse-plugin/pom.xml
maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/InstallPluginsMojo.java
Modified: maven/plugins/trunk/maven-eclipse-plugin/pom.xml
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-eclipse-plugin/pom.xml?view=diff&rev=464930&r1=464929&r2=464930
==============================================================================
--- maven/plugins/trunk/maven-eclipse-plugin/pom.xml (original)
+++ maven/plugins/trunk/maven-eclipse-plugin/pom.xml Tue Oct 17 07:22:44 2006
@@ -22,6 +22,13 @@
<build>
<plugins>
<plugin>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <source>1.4</source>
+ <target>1.4</target>
+ </configuration>
+ </plugin>
+ <plugin>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<excludes>
Modified: maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/InstallPluginsMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/InstallPluginsMojo.java?view=diff&rev=464930&r1=464929&r2=464930
==============================================================================
--- maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/InstallPluginsMojo.java (original)
+++ maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/InstallPluginsMojo.java Tue Oct 17 07:22:44 2006
@@ -170,7 +170,7 @@
try
{
- project = projectBuilder.buildFromRepository( artifact, Collections.emptyList(), localRepository,
+ project = projectBuilder.buildFromRepository( artifact, Collections.EMPTY_LIST, localRepository,
true );
}
catch ( ProjectBuildingException e )
Re: svn commit: r464930 - in /maven/plugins/trunk/maven-eclipse-plugin: pom.xml src/main/java/org/apache/maven/plugin/eclipse/InstallPluginsMojo.java
Posted by Vincent Siveton <vi...@gmail.com>.
IMHO it should be better to add this in the parent plugin.
Cheers,
Vincent
2006/10/17, joakime@apache.org <jo...@apache.org>:
> Author: joakime
> Date: Tue Oct 17 07:22:44 2006
> New Revision: 464930
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=464930
> Log:
> Ensuring that codebase works with JDK 1.4
>
>
> Modified:
> maven/plugins/trunk/maven-eclipse-plugin/pom.xml
> maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/InstallPluginsMojo.java
>
> Modified: maven/plugins/trunk/maven-eclipse-plugin/pom.xml
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-eclipse-plugin/pom.xml?view=diff&rev=464930&r1=464929&r2=464930
> ==============================================================================
> --- maven/plugins/trunk/maven-eclipse-plugin/pom.xml (original)
> +++ maven/plugins/trunk/maven-eclipse-plugin/pom.xml Tue Oct 17 07:22:44 2006
> @@ -22,6 +22,13 @@
> <build>
> <plugins>
> <plugin>
> + <artifactId>maven-compiler-plugin</artifactId>
> + <configuration>
> + <source>1.4</source>
> + <target>1.4</target>
> + </configuration>
> + </plugin>
> + <plugin>
> <artifactId>maven-surefire-plugin</artifactId>
> <configuration>
> <excludes>
>
> Modified: maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/InstallPluginsMojo.java
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/InstallPluginsMojo.java?view=diff&rev=464930&r1=464929&r2=464930
> ==============================================================================
> --- maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/InstallPluginsMojo.java (original)
> +++ maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/InstallPluginsMojo.java Tue Oct 17 07:22:44 2006
> @@ -170,7 +170,7 @@
>
> try
> {
> - project = projectBuilder.buildFromRepository( artifact, Collections.emptyList(), localRepository,
> + project = projectBuilder.buildFromRepository( artifact, Collections.EMPTY_LIST, localRepository,
> true );
> }
> catch ( ProjectBuildingException e )
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org