[GitHub] [pulsar] sijie commented on a change in pull request #3972: [Issue 3966] [pulsar-io] Specify the RedisSink type as Bytes by default

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #3972: [Issue 3966] [pulsar-io] Specify the RedisSink type as Bytes by default
URL: https://github.com/apache/pulsar/pull/3972#discussion_r271859260
 
 

 ##########
 File path: pulsar-io/redis/src/main/java/org/apache/pulsar/io/redis/sink/RedisSink.java
 ##########
 @@ -119,7 +119,7 @@ private void flush() {
         }
 
         if (CollectionUtils.isNotEmpty(recordsToFlush)) {
-            for (Record<T> record: recordsToFlush) {
+            for (Record<byte[]> record: recordsToFlush) {
                 try {
                     // records with null keys or values will be ignored
                     byte[] key = toBytes("key", record.getKey().orElse(null));
 
 Review comment:
   I think we can get rid of `toBytes` here, no?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services