You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "DaqianLiao (via GitHub)" <gi...@apache.org> on 2024/05/09 08:24:13 UTC

[PR] [Fix] The method refreshMasterList was executed one more time in function putAll. #15962 [dolphinscheduler]

DaqianLiao opened a new pull request, #15963:
URL: https://github.com/apache/dolphinscheduler/pull/15963

   <!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
   
   ## Purpose of the pull request
   
   <!--(For example: This pull request adds checkstyle plugin).-->
   
   ## Brief change log
   
   <!--*(for example:)*
   - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   
   ## Verify this pull request
   
   <!--*(Please pick either of the following options)*-->
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   <!--*(example:)*
   - *Added dolphinscheduler-dao tests for end-to-end.*
   - *Added CronUtilsTest to verify the change.*
   - *Manually verified the change by testing locally.* -->
   
   (or)
   
   If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Fix] The method refreshMasterList was executed one more time in function putAll. #15962 [dolphinscheduler]

Posted by "DaqianLiao (via GitHub)" <gi...@apache.org>.
DaqianLiao commented on PR #15963:
URL: https://github.com/apache/dolphinscheduler/pull/15963#issuecomment-2102356920

   The putAll method will loop through and call the put method, which has already called the refreshMasterList method. This method will refresh the hostIndexMap
   <img width="855" alt="image" src="https://github.com/apache/dolphinscheduler/assets/16402366/6ae5dc7c-730a-4894-a926-4cb15cc2f9d8">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Fix] The method refreshMasterList was executed one more time in function putAll. #15962 [dolphinscheduler]

Posted by "DaqianLiao (via GitHub)" <gi...@apache.org>.
DaqianLiao closed pull request #15963: [Fix] The method refreshMasterList was executed one more time in function putAll. #15962
URL: https://github.com/apache/dolphinscheduler/pull/15963


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Fix] The method refreshMasterList was executed one more time in function putAll. #15962 [dolphinscheduler]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on PR #15963:
URL: https://github.com/apache/dolphinscheduler/pull/15963#issuecomment-2102343424

   > -1 to this PR, is this will bring any bug? AFAIK, after this change will not refresh the `hostIndexMap`, the class `MasterPriorityQueue` can be refactored if you have a detail design, you can submit a DSIP to do this, otherwise the PR will not be accepted.
   
   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org