You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/25 11:16:20 UTC
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10135: fix: implement legacy druid dashboard import
codecov-commenter edited a comment on pull request #10135:
URL: https://github.com/apache/incubator-superset/pull/10135#issuecomment-649475422
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10135?src=pr&el=h1) Report
> Merging [#10135](https://codecov.io/gh/apache/incubator-superset/pull/10135?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b205ce32b0b5ead6ba98585ba22e0f9c6d3cebdd&el=desc) will **increase** coverage by `4.43%`.
> The diff coverage is `55.55%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10135?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10135 +/- ##
==========================================
+ Coverage 65.87% 70.30% +4.43%
==========================================
Files 594 594
Lines 31418 31419 +1
Branches 3215 3215
==========================================
+ Hits 20696 22089 +1393
+ Misses 10541 9213 -1328
+ Partials 181 117 -64
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.99% <ø> (?)` | |
| #javascript | `59.64% <ø> (ø)` | |
| #python | `70.10% <55.55%> (-0.20%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10135?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/10135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `61.53% <55.55%> (-1.26%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.72% <0.00%> (-12.77%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/10135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <0.00%> (-3.41%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/10135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `87.17% <0.00%> (-2.57%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.28% <0.00%> (-2.29%)` | :arrow_down: |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/10135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.00% <0.00%> (-0.96%)` | :arrow_down: |
| ... and [152 more](https://codecov.io/gh/apache/incubator-superset/pull/10135/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10135?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10135?src=pr&el=footer). Last update [b205ce3...3b85682](https://codecov.io/gh/apache/incubator-superset/pull/10135?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org