You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/10/30 12:53:20 UTC
[GitHub] [netbeans] matthiasblaesing opened a new pull request #3287: CheckRegexp hint causes all lines with regexp shown with a warning
matthiasblaesing opened a new pull request #3287:
URL: https://github.com/apache/netbeans/pull/3287
The severity of the CheckRegexp of VERIFIER causes all lines in source
files containing a regexp to be marked as warning. This is invalid, as
the regexp are perfectly ok.
The severity is reduced to HINT. That way the hint is readily available
when the regexp is under the cursor, but does not clutter the whole
file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3287: CheckRegexp hint causes all lines with regexp shown with a warning
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3287:
URL: https://github.com/apache/netbeans/pull/3287#issuecomment-955580231
Thank you all for review. I have rebased this onto delivery, but I seem to have messed up the java.hints tests. I'll look into it first and if I get the tests green (or only see the known flaky tests fail), will merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #3287: CheckRegexp hint causes all lines with regexp shown with a warning
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #3287:
URL: https://github.com/apache/netbeans/pull/3287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3287: CheckRegexp hint causes all lines with regexp shown with a warning
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3287:
URL: https://github.com/apache/netbeans/pull/3287#issuecomment-955590931
@matthiasblaesing you have to swap out `:verifier:` with `:hint:` in the test. Example is here: https://github.com/apache/netbeans/pull/3160
thanks for fixing this, I wanted to do that too but completely forgot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mishrasandeep commented on pull request #3287: CheckRegexp hint causes all lines with regexp shown with a warning
Posted by GitBox <gi...@apache.org>.
mishrasandeep commented on pull request #3287:
URL: https://github.com/apache/netbeans/pull/3287#issuecomment-955571189
>
>
> @mishrasandeep please have a look at this change
Looks Good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien edited a comment on pull request #3287: CheckRegexp hint causes all lines with regexp shown with a warning
Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3287:
URL: https://github.com/apache/netbeans/pull/3287#issuecomment-955590931
@matthiasblaesing you have to swap out `:verifier:` with `:hint:` in the test. Example is here: https://github.com/apache/netbeans/pull/3160
thanks for fixing this, I wanted to fix it myself but completely forgot.
btw if anyone here would like to review the relatively small two other hint improvement PRs: https://github.com/apache/netbeans/pull/3284 https://github.com/apache/netbeans/pull/3218 I don't have a request review button
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien edited a comment on pull request #3287: CheckRegexp hint causes all lines with regexp shown with a warning
Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3287:
URL: https://github.com/apache/netbeans/pull/3287#issuecomment-955590931
@matthiasblaesing you have to swap out `:verifier:` with `:hint:` in the test. Example is here: https://github.com/apache/netbeans/pull/3160
thanks for fixing this, I wanted to fix it myself but completely forgot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3287: CheckRegexp hint causes all lines with regexp shown with a warning
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3287:
URL: https://github.com/apache/netbeans/pull/3287#issuecomment-955204836
@mishrasandeep please have a look at this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mishrasandeep edited a comment on pull request #3287: CheckRegexp hint causes all lines with regexp shown with a warning
Posted by GitBox <gi...@apache.org>.
mishrasandeep edited a comment on pull request #3287:
URL: https://github.com/apache/netbeans/pull/3287#issuecomment-955571189
>
>
> @mishrasandeep please have a look at this change
Looks Good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3287: CheckRegexp hint causes all lines with regexp shown with a warning
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3287:
URL: https://github.com/apache/netbeans/pull/3287#issuecomment-955667323
@mbien thanks for the hint - I should have known, that there was a test, that verified this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3287: CheckRegexp hint causes all lines with regexp shown with a warning
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3287:
URL: https://github.com/apache/netbeans/pull/3287#issuecomment-955360055
@matthiasblaesing +1 and happy to merge this one into delivery if you want (it's bugging me too!). There's a whole bunch of hints that should have their level reduced - the editor is getting far too noisy IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists