You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/08 22:14:30 UTC
[GitHub] [incubator-superset] lilykuang opened a new pull request #10258: feat: update delete modal for dataset
lilykuang opened a new pull request #10258:
URL: https://github.com/apache/incubator-superset/pull/10258
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
- implement the Delete modal to match UI closer to SIP-34
- warns user about related charts and dashboard
- user need to type 'DELETE' before being able to delete the dataset
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
**AFTER**
https://www.loom.com/share/79bf03bccdea498ab6c0531494f29271
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian commented on a change in pull request #10258: feat: update delete modal for dataset
Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #10258:
URL: https://github.com/apache/incubator-superset/pull/10258#discussion_r452341171
##########
File path: superset-frontend/src/components/DeleteModal.tsx
##########
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { t } from '@superset-ui/translation';
+import React, { useState } from 'react';
+import styled from '@superset-ui/style';
+import { FormGroup, FormControl } from 'react-bootstrap';
+import Modal from 'src/components/Modal';
+
+const StyleFormGroup = styled(FormGroup)`
+ padding-top: 8px;
+ width: 50%;
+ label {
+ color: ${({ theme }) => theme.colors.grayscale.light1};
+ text-transform: uppercase;
+ }
+`;
+
+const DescriptionContainer = styled.div`
+ line-height: 40px;
+ padding-top: 16px;
+`;
+
+interface DeleteModalProps {
+ description: React.ReactNode;
+ onConfirm: () => void;
+ onHide: () => void;
+ open: boolean;
+ title: React.ReactNode;
+}
+
+export default function DeleteModal({
Review comment:
Good idea to bring this out to a separate component, this is cleaner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] lilykuang closed pull request #10258: feat: update delete modal for dataset
Posted by GitBox <gi...@apache.org>.
lilykuang closed pull request #10258:
URL: https://github.com/apache/incubator-superset/pull/10258
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian merged pull request #10258: feat: update delete modal for dataset
Posted by GitBox <gi...@apache.org>.
suddjian merged pull request #10258:
URL: https://github.com/apache/incubator-superset/pull/10258
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org