[jira] [Commented] (ZOOKEEPER-1459) Standalone ZooKeeperServer is not closing the transaction log files on shutdown

["Raul Gutierrez Segales (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836107#comment-13836107 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-1459:
---------------------------------------------------

One small nit:

{noformat}
+            if (!f.delete())
+                // double check for the file existence
+                if (f.exists()) {
+                    throw new IOException("Failed to delete file: " + f);
+                }
{noformat}

I believe all around ZK's source code if statements always have curly braces around their bodies, so:

{noformat}
+            if (!f.delete()) {
+                // double check for the file existence
+                if (f.exists()) {
+                    throw new IOException("Failed to delete file: " + f);
+                }
+            }
{noformat}

would play nicer with the incumbent coding style. 

> Standalone ZooKeeperServer is not closing the transaction log files on shutdown
> -------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1459
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1459
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.0
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>             Fix For: 3.4.6, 3.5.0
>
>         Attachments: ZOOKEEPER-1459-branch-3_4.patch, ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch
>
>
> When shutdown the standalone ZK server, its only clearing the zkdatabase and not closing the transaction log streams. When tries to delete the temporary files in unit tests on windows, its failing.
> ZooKeeperServer.java
> {noformat}
>         if (zkDb != null) {
>             zkDb.clear();
>         }
> {noformat}
> Suggestion to close the zkDb as follows, this inturn will take care transaction logs:
> {noformat}
>         if (zkDb != null) {
>             zkDb.clear();
>             try {
>                 zkDb.close();
>             } catch (IOException ie) {
>                 LOG.warn("Error closing logs ", ie);
>             }
>         }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.1#6144)