You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lenya.apache.org by bu...@apache.org on 2007/05/11 13:40:48 UTC
DO NOT REPLY [Bug 42394] New: - Revision control is broken
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42394>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42394
Summary: Revision control is broken
Product: Lenya
Version: 1.4
Platform: Other
URL: http://localhost:8888/default/authoring/index.html?lenya
.usecase=tab.revisions
OS/Version: Linux
Status: NEW
Severity: blocker
Priority: P1
Component: Revision Controller
AssignedTo: dev@lenya.apache.org
ReportedBy: thorsten@apache.org
I have the default pub with the default content. I edit and published the index.
Now in
http://localhost:8888/default/authoring/index.html?lenya.usecase=tab.revisions
I see different versions.
Requesting http://localhost:8888/default/authoring/index.html?lenya.revision=1
will show me the last revision (with all the test edition). I would have
expected it will show me the initial page (without any edition).
Trying http://localhost:8888/default/authoring/index.html?lenya.revision=2 is
throwing an ugly exception:
No entry found for
[lenya://lenya/pubs/default/content/authoring/f2027f00-ff09-11db-a881-fac2875bd236/en],
revision [2]
org.apache.cocoon.ProcessingException: Failed to process pipeline at
<map:serialize type="xml"> -
file:/home/thorsten/src/apache/lenya-1.4.x/build/lenya/webapp/lenya/modules/homepage/sitemap.xmap:65:36
at <map:transform type="cinclude"> -
file:/home/thorsten/src/apache/lenya-1.4.x/build/lenya/webapp/lenya/modules/homepage/sitemap.xmap:64:41
at <map:transform> -
...
Caused by: org.apache.excalibur.source.SourceException: Cannot get input stream
for
cocoon://modules/news/header.xml/default/authoring/f2027f00-ff09-11db-a881-fac2875bd236/en
at
org.apache.cocoon.components.source.impl.SitemapSource.getInputStream(SitemapSource.java:252)
at
org.apache.lenya.cms.cocoon.source.SiteSource.getInputStream(SiteSource.java:151)
at
org.apache.cocoon.components.source.SourceUtil.getInputSource(SourceUtil.java:522)
... 96 more
Further if I try to rollback to another version it is actually not doing anything.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42394] - [PATCH] Revision control is broken
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42394>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42394
andreas@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From andreas@apache.org 2007-05-14 08:07 -------
Done.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42394] - Revision control is broken
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42394>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42394
------- Additional Comments From andreas@apache.org 2007-05-14 05:57 -------
(In reply to comment #0)
> Requesting http://localhost:8888/default/authoring/index.html?lenya.revision=1
> will show me the last revision (with all the test edition). I would have
> expected it will show me the initial page (without any edition).
The homepage module didn't take the lenya.revision parameter into account. That
should work now.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42394] - Revision control is broken
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42394>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42394
------- Additional Comments From andreas@apache.org 2007-05-14 01:26 -------
(In reply to comment #0)
> Trying http://localhost:8888/default/authoring/index.html?lenya.revision=2 is
> throwing an ugly exception:
This is because of the news inclusion. The system tries to load revision 2 of
the news, but it doesn't exist. I guess we can't apply the revision request
parameter to the include format.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42394] - Revision control is broken
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42394>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42394
------- Additional Comments From thorsten@apache.org 2007-05-11 04:43 -------
Created an attachment (id=20174)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20174&action=view)
broken-revision-index.html
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42394] - [PATCH] Revision control is broken
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42394>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42394
thorsten@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|1.4 |2.0
Version|1.4 |2.0
------- Additional Comments From thorsten@apache.org 2007-07-16 01:59 -------
Renaming Lenya 1.4 to 2.0
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42394] - [PATCH] Revision control is broken
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42394>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42394
andreas@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Revision control is broken |[PATCH] Revision control is
| |broken
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42394] - Revision control is broken
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42394>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42394
------- Additional Comments From andreas@apache.org 2007-05-14 06:08 -------
Created an attachment (id=20191)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20191&action=view)
RepositorySource: Apply revision parameter only if it matches the main document
of the request
As I suggested on lenya-dev:
"Whenever a repository source is generated, compare its path
with the path of the HTTP request. If it is the same, use the
revision parameter, if not, don't use it. Well, if we want to
emphasize convention over configuration, this might be the
easiest solution. But the same problem occurs as with the
first option."
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42394] - [PATCH] Revision control is broken
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42394>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42394
------- Additional Comments From thorsten@apache.org 2007-05-14 07:52 -------
I tested and reviewed the patch and it seems to work fine.
Please go ahead and apply it to trunk.
TIA
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org