You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:50:14 UTC

[GitHub] [flink] danny0405 commented on pull request #13836: [FLINK-18325] [table-common] Handle null when calling SqlDataTypeSpec#getNullable

danny0405 commented on pull request #13836:
URL: https://github.com/apache/flink/pull/13836#issuecomment-720975062


   > From the implementation of `ExtendedDataType` in `flink-sql-parser/parserImpls.ftl`, the default nullable has been set to `true`. So it is always not `null` in Flink and it's safe to just call `SqlDataTypeSpec#getNullable`. However, I'm fine to add this null check. What do you think @danny0405 ?
   
   Yes, we always set the flag in Flink so it should be null-safe, but adding an explicit check is better(in case maybe there are some changes in the parser later on).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org