You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2009/05/09 17:26:42 UTC

svn commit: r773233 - in /jakarta/jmeter/trunk/src: core/org/apache/jmeter/reporters/ResultCollector.java monitor/components/org/apache/jmeter/visualizers/MonitorStats.java

Author: sebb
Date: Sat May  9 15:26:40 2009
New Revision: 773233

URL: http://svn.apache.org/viewvc?rev=773233&view=rev
Log:
Docs

Modified:
    jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
    jakarta/jmeter/trunk/src/monitor/components/org/apache/jmeter/visualizers/MonitorStats.java

Modified: jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java?rev=773233&r1=773232&r2=773233&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java (original)
+++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java Sat May  9 15:26:40 2009
@@ -492,6 +492,7 @@
      * @param e
      * @throws Exception
      */
+    // Used by: MonitorHealthVisualizer.add(SampleResult res)
     public void recordStats(TestElement e) throws Exception {
         if (out == null) {
             initializeFileOutput();

Modified: jakarta/jmeter/trunk/src/monitor/components/org/apache/jmeter/visualizers/MonitorStats.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/monitor/components/org/apache/jmeter/visualizers/MonitorStats.java?rev=773233&r1=773232&r2=773233&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/monitor/components/org/apache/jmeter/visualizers/MonitorStats.java (original)
+++ jakarta/jmeter/trunk/src/monitor/components/org/apache/jmeter/visualizers/MonitorStats.java Sat May  9 15:26:40 2009
@@ -20,6 +20,14 @@
 
 import org.apache.jmeter.testelement.AbstractTestElement;
 
+/*
+ *  TODO - convert this into an immutable class using plain variables
+ *  The current implementation is quite inefficient, as it stores everything
+ *  in properties.
+ *  
+ *  This will require changes to ResultCollector.recordStats()
+ *  and SaveService.saveTestElement() which are both currently only used by Monitor classes
+ */
 public class MonitorStats extends AbstractTestElement implements Serializable {
 
     private static final String HEALTH = "stats.health";



---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org